Fix stale command-palette locator in manual audit - #2476
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice. |
|
Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed ShellCommandPalette.vue renders role=combobox with aria-label 'Command palette search', the Paper and Shell palettes are mutually exclusive in AppShell.vue so the locator is unambiguous, and smoke.spec.ts already uses the identical locator. Not executed against a live stack (audit is opt-in via TASKDECK_RUN_AUDIT=1). Verdict SHIP. Merging. |
Summary
Replace the obsolete command-palette placeholder locator in the headed manual audit with the existing accessible combobox name contract. This keeps the product UI and command behavior unchanged while removing deterministic audit drift.
Implementation
manual-audit.spec.tsto locate the command-palette search input by role and accessible name, matching the existing smoke coverage.Verification
npx playwright test tests/e2e/manual-audit.spec.ts --headed --grep 'command palette search navigates to inbox' --reporter=line— passed (1 test)npx eslint tests/e2e/manual-audit.spec.ts— passedgit diff --check— passednpm cipopulated the isolated worktree and emitted existing engine/deprecation warnings before returning nonzero.npm ls --depth=0 --omit=optionalconfirmed the required packages were present.Documentation
No documentation update: this is a test-only locator repair.
Risk Notes
Closes #1763