Skip to content

Fix stale command-palette locator in manual audit - #2476

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-1763/repair-command-palette-locator
Sep 4, 2026
Merged

Fix stale command-palette locator in manual audit#2476
Chris0Jeky merged 1 commit into
mainfrom
issue-1763/repair-command-palette-locator

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

Replace the obsolete command-palette placeholder locator in the headed manual audit with the existing accessible combobox name contract. This keeps the product UI and command behavior unchanged while removing deterministic audit drift.

Implementation

  • Updated manual-audit.spec.ts to locate the command-palette search input by role and accessible name, matching the existing smoke coverage.

Verification

  • npx playwright test tests/e2e/manual-audit.spec.ts --headed --grep 'command palette search navigates to inbox' --reporter=line — passed (1 test)
  • npx eslint tests/e2e/manual-audit.spec.ts — passed
  • git diff --check — passed
  • Initial run without dependencies was not a test result; npm ci populated the isolated worktree and emitted existing engine/deprecation warnings before returning nonzero. npm ls --depth=0 --omit=optional confirmed the required packages were present.

Documentation

No documentation update: this is a test-only locator repair.

Risk Notes

  • Security impact: none.
  • Behavior/regression risk: test-only; the accessible product contract is already exercised by smoke coverage.
  • Follow-up tasks: none.

Closes #1763

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed ShellCommandPalette.vue renders role=combobox with aria-label 'Command palette search', the Paper and Shell palettes are mutually exclusive in AppShell.vue so the locator is unambiguous, and smoke.spec.ts already uses the identical locator. Not executed against a live stack (audit is opt-in via TASKDECK_RUN_AUDIT=1). Verdict SHIP. Merging.

@Chris0Jeky
Chris0Jeky merged commit a84d350 into main Sep 4, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Testing] Repair stale command-palette locator in headed manual audit

1 participant