Skip to content

Correct documented chat message types - #2477

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2078/correct-chat-message-docs
Sep 4, 2026
Merged

Correct documented chat message types#2477
Chris0Jeky merged 1 commit into
mainfrom
issue-2078/correct-chat-message-docs

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • Correct the chat API example to use the implemented proposal-reference message type.
  • Document all seven values from ChatMessage.ValidMessageTypes, including when each is emitted.

Verification

  • node scripts/check-docs-governance.mjs
  • git diff --check
  • Backend, frontend, and Playwright checks not run; this is a documentation-only change.

Documentation

  • docs/STATUS.md updated (not applicable; no shipped behavior changed)
  • docs/IMPLEMENTATION_MASTERPLAN.md updated (not applicable)
  • docs/TESTING_GUIDE.md / docs/MANUAL_TEST_CHECKLIST.md updated (not applicable)

Tracking

CI Workflow Validation

  • Not applicable; no workflow, deploy, script, or project-file changes.

Risk Notes

  • Security impact: None.
  • Behavior/regression risk: None; documentation only.
  • Follow-up tasks: None.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer verified every changed line against the domain whitelist in ChatMessage.cs and the ChatService emission sites; the corrected example matches ChatApiTests. Verdict SHIP. Two LOW doc-truth residuals outside the fix (status semantics wording, DATA_MODEL.md omits parse-hint) tracked in #2488. Merging.

@Chris0Jeky
Chris0Jeky merged commit d25e821 into main Sep 4, 2026
20 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

docs/api/CHAT.md documents a message type that does not exist and omits four that do

1 participant