Skip to content

Use historical copy for Legacy applied proposals - #2480

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2121/legacy-settled-review-copy
Sep 4, 2026
Merged

Use historical copy for Legacy applied proposals#2480
Chris0Jeky merged 1 commit into
mainfrom
issue-2121/legacy-settled-review-copy

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • Make the Legacy review card use the proposal's durable summary and a recorded/applied impact cue for Applied records.
  • Preserve the populated backend presentation copy for pending proposals.
  • Add an API-shaped regression covering both statuses with the same prospective presentation payload.

Verification

  • npx vitest --run --maxWorkers=2 src/tests/components/review/ReviewProposalCard.diff.spec.ts (17 passed)
  • npm run typecheck
  • Scoped ESLint for the changed component and spec
  • git diff --check
  • Playwright/E2E not run; this is a focused rendering change.

Documentation

  • docs/STATUS.md updated (no strategy or shipped-behavior documentation change needed)
  • docs/IMPLEMENTATION_MASTERPLAN.md updated (not applicable)
  • docs/TESTING_GUIDE.md / docs/MANUAL_TEST_CHECKLIST.md updated (not applicable)

Tracking

CI Workflow Validation

  • Not applicable; no workflow, deploy, script, or project-file changes.

Risk Notes

  • Security impact: None.
  • Behavior/regression risk: Applied Legacy cards no longer show prospective presentation copy; pending cards retain the existing path.
  • Follow-up tasks: None.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed the status discriminator matches the backend enum (normalizeProposalStatus), ProposalDto.Summary is required and always populated, and the new spec contradicts the pre-change output for the same presentation payload. Frontend Unit green at this head. Verdict SHIP. MEDIUM follow-up (Rejected/Failed/Expired/Dismissed still show prospective copy) plus two LOWs tracked in #2493.

@Chris0Jeky
Chris0Jeky merged commit 7545b36 into main Sep 4, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Frontend][Legacy][Review] ReviewProposalCard renders prospective presentation copy for settled records

1 participant