Use historical copy for Legacy applied proposals - #2480
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed the status discriminator matches the backend enum (normalizeProposalStatus), ProposalDto.Summary is required and always populated, and the new spec contradicts the pre-change output for the same presentation payload. Frontend Unit green at this head. Verdict SHIP. MEDIUM follow-up (Rejected/Failed/Expired/Dismissed still show prospective copy) plus two LOWs tracked in #2493. |
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Appliedrecords.Verification
npx vitest --run --maxWorkers=2 src/tests/components/review/ReviewProposalCard.diff.spec.ts(17 passed)npm run typecheckgit diff --checkDocumentation
docs/STATUS.mdupdated (no strategy or shipped-behavior documentation change needed)docs/IMPLEMENTATION_MASTERPLAN.mdupdated (not applicable)docs/TESTING_GUIDE.md/docs/MANUAL_TEST_CHECKLIST.mdupdated (not applicable)Tracking
Reviewwhile this PR is open)CI Workflow Validation
Risk Notes
presentationcopy; pending cards retain the existing path.