Skip to content

[Capture] Clear uncommitted label draft after successful submit - #2481

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2057/draft-reset
Sep 4, 2026
Merged

[Capture] Clear uncommitted label draft after successful submit#2481
Chris0Jeky merged 1 commit into
mainfrom
issue-2057/draft-reset

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Closes #2057

Summary

  • clear the transient label input when the parent confirms a successful Paper capture reset
  • keep the uncommitted input intact until that success confirmation
  • cover both states in the focused composer spec

Verification

  • npm test -- --maxWorkers=2 src/tests/views/paper/inbox/PaperCaptureComposer.spec.ts
  • npm run typecheck
  • npx eslint src/views/paper/inbox/PaperCaptureComposer.vue src/tests/views/paper/inbox/PaperCaptureComposer.spec.ts
  • git diff --check

ESLint reports one existing vuejs-accessibility/label-has-for warning at PaperCaptureComposer.vue:261; no errors.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed resetDraft fires only after captureStore.createItem resolves (PaperInboxView.vue:191) or on explicit discard, never on failure or board-scope change; the in-flight race is closed by the disabled label input while submitting; the spec drives the real exposed resetDraft. Frontend Unit passed at this head in CI. Verdict SHIP. MEDIUM follow-up (submit does not flush an uncommitted label, so the clear is lossy) plus two LOW residuals tracked in #2490. Merging.

@Chris0Jeky
Chris0Jeky merged commit a06a89a into main Sep 4, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 4, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-2057/draft-reset branch September 6, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Capture] Clear uncommitted label draft after successful submit

1 participant