Skip to content

[Capture][a11y] Fix diagnostics mock and receipt announcement replay - #2486

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2147/receipt-a11y
Sep 4, 2026
Merged

[Capture][a11y] Fix diagnostics mock and receipt announcement replay#2486
Chris0Jeky merged 1 commit into
mainfrom
issue-2147/receipt-a11y

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Closes #2147

Summary

  • complete the integration test error-mapper mock and pin API error propagation
  • announce a failed capture receipt with role=alert once, then keep it visible without replay when revisited
  • preserve the existing draft, error association, and per-variant behavior

Verification

  • npm ci --no-audit --no-fund
  • npm test -- --maxWorkers=2 src/tests/store/captureStore.integration.spec.ts src/tests/views/paper/PaperInboxView.spec.ts
  • npm run typecheck
  • npx eslint src/views/paper/PaperInboxView.vue src/tests/store/captureStore.integration.spec.ts src/tests/views/paper/PaperInboxView.spec.ts
  • git diff --check

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed the acknowledged flag is per-variant and reset on every new failure (so a later failure re-announces), the retry path unmounts and remounts the alert node, the success role=status regions are untouched, and the mock completion strengthens the store assertion to rethrow the original API error. Verdict SHIP. Three LOWs declined as non-blocking, noted for #2147's owner: no spec asserts the re-announce half (a second mockRejectedValueOnce + role===alert would close it); captureErrorAcknowledged is not cleared when the error clears (harmless today); the remount ordering is reasoned, not executed.

@Chris0Jeky
Chris0Jeky merged commit a0bac7e into main Sep 4, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 4, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-2147/receipt-a11y branch September 6, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Frontend][Tests][a11y] PR #2145 follow-ups: integration-spec mock masks diagnostics path; stale receipt re-announces on variant toggle

1 participant