Skip to content

[Frontend][Board] Keep mutation failures visible beside load errors - #2495

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2430/board-mutation-alert
Sep 4, 2026
Merged

[Frontend][Board] Keep mutation failures visible beside load errors#2495
Chris0Jeky merged 1 commit into
mainfrom
issue-2430/board-mutation-alert

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Closes #2430

Summary

  • keep a board-load alert and a later, distinct mutation failure visible at the same time
  • keep Retry attached only to the board-load alert
  • preserve loaded Legacy and Paper board content, including the Paper empty-board local error

Verification

  • npm ci --no-audit --no-fund
  • npm test -- --maxWorkers=2 src/tests/views/BoardView.spec.ts src/tests/views/paper/PaperBoardView.spec.ts
  • npm run typecheck
  • npx eslint src/views/BoardView.vue src/views/paper/PaperBoardView.vue src/tests/views/BoardView.spec.ts src/tests/views/paper/PaperBoardView.spec.ts
  • git diff --check

Scope/docs check: no canonical docs change is required.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex credits exhausted, SC-9): one fresh-context reviewer confirmed both alerts are distinct sections with Retry bound only to the load alert, that a stale fetch cannot write another board's message into state.error (boardCrudStore generation guard at :237, route change clears both errors), and that the specs assert simultaneity with exact text. Frontend Unit green at this head. Verdict SHIP. Three LOWs declined as non-blocking: value-equality dedupe can hide a mutation error whose text equals the load error (toast still fires); two role=alert regions can announce together; #2496 touches the same lifecycle lines — it will need a rebase after this lands. Merging in the next batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Frontend][Board] Keep mutation failures visible beside load errors

1 participant