build: Fallout CI + nuget.org Trusted Publishing (Chrison.* IDs)#20
Merged
Conversation
Convert the build/CI to the Fallout pipeline and retarget publishing from GitHub Packages to nuget.org via Trusted Publishing (OIDC, no stored key). - build/: Fallout build project (Compile/Test/Pack/Publish targets) + build.sh/ps1 + .fallout/ root marker; nuget.config gains the Fallout-build feed (Fallout.* only). - Rename package IDs to the Chrison.* prefix (Chrison.ProxmoxSharp[.Api|.Cli]) — the bare ProxmoxSharp/UnifiSharp IDs are taken on nuget.org by unrelated projects. AssemblyName/RootNamespace stay ProxmoxSharp, so `using ProxmoxSharp;` is unchanged. - ci.yml → build+test only; publish.yml → NuGet/login@v1 OIDC → dotnet push to nuget.org (prerelease on main, stable on v* tag). - Fix CI regression: restore microsoft.openapi.kiota 1.31.1 to the tool manifest (dropped in #18), which broke the codegen step — CI red since 2026-06-29. - README: Build/CLI/Packages sections updated for Fallout + Chrison.* on nuget.org. Verified locally: ./build.sh Pack → 40 tests pass, emits Chrison.ProxmoxSharp*.nupkg. Requires (repo/org setup): PACKAGES_PAT secret (read:packages on Fallout-build), NUGET_USER secret (nuget.org profile), and a nuget.org Trusted Publishing policy for this repo + publish.yml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The nuget.org TP policy scopes to Environment=Nuget.org, so the publish job must declare `environment: Nuget.org` — the OIDC token only carries the environment claim when the job sets it, and the token exchange is rejected otherwise. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 23, 2026
ChrisonSimtian
added a commit
to Chrison-dev/UnifiSharp
that referenced
this pull request
Jul 23, 2026
Mirror the ProxmoxSharp conversion (PR Chrison-dev/ProxmoxSharp#20): - build/: Fallout build project (Compile/Test/Pack/Publish) + build.sh/ps1 + .fallout/ root marker; new nuget.config adds the Fallout-build feed (Fallout.* only). - Rename package IDs to the Chrison.* prefix (Chrison.UnifiSharp[.Api|.Cli]) — the bare UnifiSharp ID is taken on nuget.org (anthturner). AssemblyName/RootNamespace stay UnifiSharp, so `using UnifiSharp;` and the `unifisharp` command are unchanged. - ci.yml → build+test only; publish.yml → NuGet/login@v1 OIDC → push to nuget.org (prerelease on main, stable on v* tag), job runs in the Nuget.org environment. - README: Build + Packages sections updated for Fallout + Chrison.* on nuget.org. Verified locally: ./build.sh Pack → 16 tests pass, emits Chrison.UnifiSharp*.nupkg. Requires (repo setup): PACKAGES_PAT + NUGET_USER secrets, a Nuget.org GH environment, and a nuget.org Trusted Publishing policy for this repo + publish.yml (Environment=Nuget.org). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts ProxmoxSharp's build/CI to the Fallout pipeline and retargets publishing
from GitHub Packages to nuget.org via Trusted Publishing (OIDC — no stored API key).
This is the template for the same change on UnifiSharp + SynoSharp, and it unblocks
P0 of the org-migration epic (
Chrison-dev/Homelab#282) — decoupling the*SharpNuGet feed from the GitHub org.
What changed
build/_build.csproj+build/Build.cs, run viabuild.sh/build.ps1):Compile → Test → Pack → Publishtargets wrappingdotnet. Adds a.fallout/rootmarker and the Fallout-build feed to
nuget.config(scoped toFallout.*only).Chrison.*package IDs —Chrison.ProxmoxSharp,Chrison.ProxmoxSharp.Api,Chrison.ProxmoxSharp.Cli. The bareProxmoxSharp/UnifiSharpIDs are already takenon nuget.org by unrelated projects. AssemblyName/RootNamespace stay
ProxmoxSharp—using ProxmoxSharp;and the CLI commandproxmoxsharpare unchanged.ci.yml→ build+test only;publish.yml→NuGet/login@v1OIDC →dotnet nuget pushto nuget.org (prerelease onmain, stable onv*tag).microsoft.openapi.kiota1.31.1 to the tool manifest(accidentally dropped in feat(repo): client-side git guardrails (Husky.NET pre-push hook) #18); the codegen step has failed since 2026-06-29, so CI has
been red for ~a month. This turns it green again.
Verified locally
./build.sh Pack→ 40 tests pass, emitsChrison.ProxmoxSharp{,.Api,.Cli}.nupkg.The
Publishtarget fails fast with a clear message if no key is supplied.PACKAGES_PATsecret on this repo (or Chrison-dev org, visible here) — a PAT withread:packageson the Fallout-build org, so CI can restoreFallout.*.NUGET_USERsecret — your nuget.org profile name (not email).Chrison-dev· Repository:ProxmoxSharp· Workflow File:publish.yml· Environment: (leave blank)Chrison.*ID-prefix reservation on nuget.org — not required to publish, just adds the verified check.Once 1–3 are in place: merge → a push to
mainpublishes a prerelease; av*tag cuts a stable release.Note: consumer updates (Homelab engine
PackageReference+nuget.config→Chrison.*on nuget.org) are intentionally not in this PR — they belong to the Homelab-side migration (#282, P6), after the packages are live.