Convert the :navigation cluster to command types (#392)#25
Open
ChrisonSimtian wants to merge 1 commit into
Open
Convert the :navigation cluster to command types (#392)#25ChrisonSimtian wants to merge 1 commit into
ChrisonSimtian wants to merge 1 commit into
Conversation
Lift the five directory-navigation handlers into discrete command types with their names preserved (GetNextDirectory, PopDirectory, PushWithCurrentRootDirectory, PushWithParentRootDirectory, PushWithChosenRootDirectory) so the companion shell functions keep working. Shared per-session state moves into an internal NavigationSession helper; PushWithChosenRootDirectory takes IConsolePrompts via the constructor. Replaces the five DelegateCommand adapters; deletes Program.Navigation.cs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 30, 2026
dennisdoomen
approved these changes
Jul 4, 2026
| namespace Fallout.Cli.Commands.Navigation; | ||
|
|
||
| /// <summary><c>fallout :GetNextDirectory</c>: prints (and consumes) the queued next directory.</summary> | ||
| public sealed class GetNextDirectoryCommand : IFalloutCommand |
There was a problem hiding this comment.
🤔 They don't have to be public, do they? If not, keep them internal, so our IDEs will also flag dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Fallout-build#392. Stacked on #16 — merge after it lands.
Per the locked decision, the five navigation verbs become discrete commands with names preserved (
GetNextDirectory,PopDirectory,PushWithCurrentRootDirectory,PushWithParentRootDirectory,PushWithChosenRootDirectory) so the documented shell functions (nuke-/nuke//nuke./nuke..) keep working. Shared per-session state moves into aninternal NavigationSession;PushWithChosenRootDirectoryCommandtakesIConsolePrompts. Replaces the fiveDelegateCommandadapters; deletesProgram.Navigation.cs.Verification
Fallout.Cli.Tests30 pass.Re-raised fork-internally to move the cli-cmd stack off the main repo. Supersedes Fallout-build#403; same history and diff.
🤖 Generated with Claude Code