fix(testing): harden production admission readiness - #16
Merged
Conversation
added 5 commits
September 2, 2026 19:40
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authority boundary
This PR references #12 but does not close it. Production Authorization, Runtime fact, Cleanup receipt, and external schema adapters remain blocked until the owning repositories publish formal endpoints, authentication, versions, and digests.
No production secret, temporary endpoint, fixture-derived authority, or second authoritative external schema copy is introduced.
Verification
npm run buildnpm run typechecknpm run lintnpm run build:control-plane-runtimenpm run build:worker-runtimenpm run verify:runtime-distributions: Testing Protocol 18 files / 6 modules; control plane 84 / 28; worker 87 / 29npm run bundle:workernpm run generate:testing-fixtureswith no driftnpm test: 284 passednpm run test:mongo-contract: 10 passednpm run demo:testing-contractnpm run demo:testing-contract -- --json/appsurface of both final imagesCI note: the first Test attempt surfaced the existing interactive worker-proxy completion race (
409between sequential actions); the single failed-job rerun passed without a code change. The image/build/demo jobs passed, and the race remains outside this Testing PR scope.All five commits received focused read-only subagent reviews. The independent full-PR review found one P1 final-image fixture leak; commit
319b5b6fixed it. A follow-up review found that start-only Authorization providers could be misclassified as admission-ready; commit49d08b6now requires both start and reconcile authorization capabilities. The same reviewers re-reviewed both fixes with no remaining findings.Preflight
qa-tools@2cff6a5edb520809955c22bfce553d7a2625cfe7codex/testing-admission-readiness@49d08b68878bcbf19970008c25e5602e8120dbd8