fix(weather): recover missing moonset and show true moon illumination on the almanac page - #157
Closed
rpierce99 wants to merge 3 commits into
Closed
fix(weather): recover missing moonset and show true moon illumination on the almanac page#157rpierce99 wants to merge 3 commits into
rpierce99 wants to merge 3 commits into
Conversation
The almanac (moon) page had two defects: 1. Once a month the moonset slot showed "---". astral only searches a single calendar day, so on the day the moon's set straddles midnight it raises "Moon never sets on this date" even though the moon sets that afternoon (sffjunkie/astral ChuckBuilds#88, ChuckBuilds#105, both open as of astral 3.2, the latest release). When astral fails, fall back to scanning the moon's elevation across the day and bisecting the horizon crossing with astral's own ephemeris. Matches astral to the minute on normal days; the same fallback covers moonrise. 2. The "illumination %" was actually the cycle fraction, so a waning crescent read 86% instead of ~13% lit. Convert phase to true illuminated fraction. Adds test_almanac_moon_data.py (fails before, passes after) covering the 2026-06-11 Federal Way moonset astral can't compute and the illumination conversion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughWeather plugin v2.5.1 fixes moon illumination (now cosine-based percent) and adds a moonrise/moonset fallback when Astral fails for events that straddle midnight; regression tests and manifest/registry metadata are updated. ChangesMoon Data Fixes
Possibly Related PRs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 29 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
plugins/ledmatrix-weather/manifest.json (1)
4-32:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRelease-date metadata is only half-updated in
plugins/ledmatrix-weather/manifest.jsonandplugins.json. The new2.5.1release is dated2026-06-11, butplugins/ledmatrix-weather/manifest.jsonstill leaveslast_updatedat2026-06-10, andplugins.jsonstill leaves the weather entry’slast_updatedat2026-06-10. Updating both fields together avoids stale cache/freshness signals for the new weather release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/ledmatrix-weather/manifest.json` around lines 4 - 32, Update the release-date metadata by setting the JSON key "last_updated" to "2026-06-11" for both the plugin manifest and the global plugins listing: edit the plugin's manifest.json entry that contains "version": "2.5.1" and change its "last_updated" value, and also update the corresponding entry in plugins.json for the weather plugin so its "last_updated" matches the new release date; ensure the date strings match exactly "2026-06-11".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/ledmatrix-weather/manager.py`:
- Around line 738-750: The try/except around astral_moon.moonrise() and
astral_moon.moonset currently swallows all exceptions; change it to only catch
ValueError that matches Astral’s “Moon never rises on this date, at this
location” / “Moon never sets on this date, at this location” messages and call
self._moon_event_fallback(...) in that case, but re-raise any other exception.
Locate the moonrise and moonset calls in the block that computes
moonrise_dt/moonset_dt (the methods invoking astral_moon.moonrise and
astral_moon.moonset) and replace the broad except Exception with logic that
checks isinstance(e, ValueError) and the error string before using the fallback,
otherwise raise the exception.
In `@plugins/ledmatrix-weather/test_almanac_moon_data.py`:
- Around line 46-49: Replace the broad except Exception around the
astral_moon.moonset(OBS, d, tzinfo=TZ) call with an except ValueError that only
swallows the specific "Moon never sets on this date, at this location" condition
(e.g., except ValueError as exc and assert or check that "Moon never sets" is in
str(exc)); leave the other except Exception as exc blocks (lines 73-77)
unchanged so unexpected errors still fail the test. This targets the
astral_moon.moonset failure case and avoids hiding unrelated exceptions while
preserving the astral_raised boolean behavior.
---
Outside diff comments:
In `@plugins/ledmatrix-weather/manifest.json`:
- Around line 4-32: Update the release-date metadata by setting the JSON key
"last_updated" to "2026-06-11" for both the plugin manifest and the global
plugins listing: edit the plugin's manifest.json entry that contains "version":
"2.5.1" and change its "last_updated" value, and also update the corresponding
entry in plugins.json for the weather plugin so its "last_updated" matches the
new release date; ensure the date strings match exactly "2026-06-11".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8f776f21-fdf9-4cc8-a4d0-9669497ccfa9
📒 Files selected for processing (5)
plugins.jsonplugins/ledmatrix-weather/CHANGELOG.mdplugins/ledmatrix-weather/manager.pyplugins/ledmatrix-weather/manifest.jsonplugins/ledmatrix-weather/test_almanac_moon_data.py
Address PR review: the blind `except Exception` around astral's
moonrise/moonset could mask unrelated errors and silently render the
fallback. Catch astral's documented `ValueError` ("Moon never rises/sets
on this date") for the fallback, keep its inconsistent `None` return as
the same recovery path, and log any other unexpected error while
reporting that one field as missing.
Deliberately do NOT re-raise unexpected errors as the reviewer suggested:
update() wraps the whole fetch in an except-Exception backoff, so
propagating would blank the entire weather widget over a secondary moon
field. Refactored the duplicated moonrise/moonset wiring into
_astral_moon_event(). Test guard narrowed to the specific ValueError.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Address PR review: the 2.5.1 versions[] entry is dated 2026-06-11 but both last_updated fields (manifest.json and the plugins.json weather entry) were left at 2026-06-10, giving stale freshness signals for the new release. update_registry.py only syncs last_updated on a version increase, so re-running after the earlier bump didn't catch it; set both to 2026-06-11 to match the release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Addressed the |
Contributor
Author
ChuckBuilds
pushed a commit
that referenced
this pull request
Jun 15, 2026
…mes (2.5.1) (#163) Combines the two open almanac (moon) page PRs into a single 2.5.1 release so they don't both claim the same version. Supersedes #157 and #159. - Recover missing moonset: astral only searches a single calendar day, so once a month the event straddles midnight and it raises "Moon never sets on this date" (sffjunkie/astral #88, #105). Fall back to scanning the moon's elevation across the day and bisecting the horizon crossing. Same fallback covers moonrise. - Show true illumination: the "%" next to the phase name showed cycle progress (so a waning crescent read 86% instead of ~13% lit); it now converts phase to the true illuminated fraction. - Restore full moon-phase names ("Waxing/Waning Crescent", "Waxing/Waning Gibbous") now that the redesigned layout has room: full name where it fits, abbreviation when tight, character trim only as a last resort. Tests: test_almanac_moon_data.py, extended test_almanac_layout.py (incl. the full-name assertions), and test_geocode_cache.py all pass. Almanac golden images regenerated for the combined output and the plugin safety harness passes at every supported size. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes to the weather plugin's almanac (moon) page.
1. Missing moonset (
---)Once per lunar month the moonset slot rendered
---. astral'smoonset()only searches within a single calendar day, so on the day the moon's set straddles local midnight it raises "Moon never sets on this date, at this location" even though the moon plainly sets that afternoon.This is a known, open, unreleased astral bug — sffjunkie/astral#88 (2023) and #105 (2026) — and 3.2 is the latest release on PyPI, so there's no upgrade to wait for.
Real example — Federal Way, WA on 2026-06-11: moon rises 02:24, sets ~17:23, but
astral.moonset()raises. The fix catches the failure and recovers the time by scanning the moon's elevation across the local day (using astral's ownmoon.elevation()ephemeris) and bisecting the horizon crossing. No new dependencies, no orbital math reimplemented. The same fallback covers moonrise.It agrees with astral to the minute on normal days (verified against 2026-06-12: rise 02:48 vs astral 02:49, set 18:50 vs 18:50), so it only ever changes the broken days.
2. "Illumination %" was cycle progress, not lit fraction
The percentage next to the phase name was
int(moon_phase * 100), butmoon_phaseis progress through the cycle (0=new, 0.5=full, 0.75=last quarter), not the illuminated fraction. So a waning crescent read "86%" when it's ~13% lit. They only agree at the quarters. Now converted via(1 − cos(2π·phase)) / 2.Tests
test_almanac_moon_data.py— fails before, passes after. Covers the 2026-06-11 moonset astral can't compute, fallback/astral agreement on a normal day, and the illumination conversion (incl. that a crescent no longer reads as its cycle fraction).test_almanac_layout.pyandtest_geocode_cache.pystill pass.check_plugin.py) passes forledmatrix-weatherat every panel size.Version
Patch bump
2.5.0 → 2.5.1;plugins.json, manifestversions[], and CHANGELOG updated.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests
Chores