chore: move fine-tuning config fields behind Advanced Settings (x-advanced) across ChuckBuilds plugins - #208
Merged
Conversation
…ced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…anced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…dvanced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…anced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…anced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
… Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
This was referenced Jul 17, 2026
Closed
Closed
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
📝 WalkthroughWalkthroughThis PR annotates configuration schemas across many plugins with ChangesAdvanced Settings metadata rollout
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
… Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
Up to standards ✅🟢 Issues
|
…dvanced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…nced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…tings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…nced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ttings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…d Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ngs (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ngs (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…(x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ettings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…nced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…s (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ettings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ettings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ngs (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…ettings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…tings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…anced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…; re-bump baseball x-advanced release to 1.19.2 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/baseball-scoreboard/manifest.json`:
- Around line 33-38: Replace the ledmatrix_min_version field with ledmatrix_min
in the version entries for plugins/baseball-scoreboard/manifest.json lines
33-38, plugins/calendar/manifest.json lines 38-43, and
plugins/news/manifest.json lines 23-28, preserving the existing values.
In `@plugins/countdown/manifest.json`:
- Around line 24-29: Rename the ledmatrix_min_version field to ledmatrix_min in
the new release entries of plugins/countdown/manifest.json (lines 24-29),
plugins/on-air/manifest.json (lines 14-19), and
plugins/static-image/manifest.json (lines 21-26), ensuring each entry contains
released, version, and ledmatrix_min.
In `@plugins/football-scoreboard/manifest.json`:
- Around line 27-32: Rename the ledmatrix_min_version key to ledmatrix_min in
the top changelog entry of plugins/football-scoreboard/manifest.json (lines
27-32) and plugins/stock-news/manifest.json (lines 28-33), without changing the
associated version, release date, or notes.
In `@plugins/ledmatrix-weather/manifest.json`:
- Line 32: Update the new version entry in the manifest’s versions array to
rename the ledmatrix_min_version field to ledmatrix_min, preserving the existing
minimum version value.
In `@plugins/odds-ticker/manifest.json`:
- Around line 23-28: Update the new top entry in the manifest’s versions array
to replace the ledmatrix_min_version key with ledmatrix_min, preserving its
existing version constraint and all other entry fields.
In `@plugins/soccer-scoreboard/config_schema.json`:
- Around line 175-176: Apply the same advanced metadata used by
predefined-league fields to the corresponding custom_leagues properties,
including exclusions, display modes, durations, filtering boosts, and
dynamic-duration settings. Update each equivalent custom-league schema field
with the existing advanced marker while preserving its current description and
validation rules.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 533bb1bb-84f5-45f0-9a81-2ac43c0e1115
📒 Files selected for processing (65)
plugins.jsonplugins/afl-scoreboard/config_schema.jsonplugins/afl-scoreboard/manifest.jsonplugins/baseball-scoreboard/config_schema.jsonplugins/baseball-scoreboard/manifest.jsonplugins/basketball-scoreboard/config_schema.jsonplugins/basketball-scoreboard/manifest.jsonplugins/calendar/config_schema.jsonplugins/calendar/manifest.jsonplugins/christmas-countdown/config_schema.jsonplugins/christmas-countdown/manifest.jsonplugins/clock-simple/config_schema.jsonplugins/clock-simple/manifest.jsonplugins/countdown/config_schema.jsonplugins/countdown/manifest.jsonplugins/cricket-scoreboard/config_schema.jsonplugins/cricket-scoreboard/manifest.jsonplugins/f1-scoreboard/config_schema.jsonplugins/f1-scoreboard/manifest.jsonplugins/football-scoreboard/config_schema.jsonplugins/football-scoreboard/manifest.jsonplugins/geochron/config_schema.jsonplugins/geochron/manifest.jsonplugins/hockey-scoreboard/config_schema.jsonplugins/hockey-scoreboard/manifest.jsonplugins/lacrosse-scoreboard/config_schema.jsonplugins/lacrosse-scoreboard/manifest.jsonplugins/ledmatrix-flights/config_schema.jsonplugins/ledmatrix-flights/manifest.jsonplugins/ledmatrix-leaderboard/config_schema.jsonplugins/ledmatrix-leaderboard/manifest.jsonplugins/ledmatrix-music/config_schema.jsonplugins/ledmatrix-music/manifest.jsonplugins/ledmatrix-weather/config_schema.jsonplugins/ledmatrix-weather/manifest.jsonplugins/march-madness/config_schema.jsonplugins/march-madness/manifest.jsonplugins/masters-tournament/config_schema.jsonplugins/masters-tournament/manifest.jsonplugins/mqtt-notifications/config_schema.jsonplugins/mqtt-notifications/manifest.jsonplugins/news/config_schema.jsonplugins/news/manifest.jsonplugins/nfl-draft/config_schema.jsonplugins/nfl-draft/manifest.jsonplugins/nrl-scoreboard/config_schema.jsonplugins/nrl-scoreboard/manifest.jsonplugins/odds-ticker/config_schema.jsonplugins/odds-ticker/manifest.jsonplugins/of-the-day/config_schema.jsonplugins/of-the-day/manifest.jsonplugins/olympics/config_schema.jsonplugins/olympics/manifest.jsonplugins/on-air/config_schema.jsonplugins/on-air/manifest.jsonplugins/soccer-scoreboard/config_schema.jsonplugins/soccer-scoreboard/manifest.jsonplugins/static-image/config_schema.jsonplugins/static-image/manifest.jsonplugins/stock-news/config_schema.jsonplugins/stock-news/manifest.jsonplugins/text-display/config_schema.jsonplugins/text-display/manifest.jsonplugins/tide-display/config_schema.jsonplugins/tide-display/manifest.json
Comment on lines
+27
to
+32
| { | ||
| "released": "2026-07-17", | ||
| "version": "2.8.3", | ||
| "ledmatrix_min_version": "2.0.0", | ||
| "notes": "Config schema reorganized for a clearer setup experience: fine-tuning fields moved behind the web UI's collapsed Advanced Settings section (x-advanced). UX-only; no fields, defaults, or behavior changed." | ||
| }, |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use ledmatrix_min instead of ledmatrix_min_version.
As per coding guidelines, the new version entry in manifest.json must use ledmatrix_min for the minimum LEDMatrix version requirement. Both manifests mistakenly use the ledmatrix_min_version key in their top changelog entries.
plugins/football-scoreboard/manifest.json#L27-L32: Rename"ledmatrix_min_version"to"ledmatrix_min".plugins/stock-news/manifest.json#L28-L33: Rename"ledmatrix_min_version"to"ledmatrix_min".
📝 Proposed fixes
For plugins/football-scoreboard/manifest.json:
- "ledmatrix_min_version": "2.0.0",
+ "ledmatrix_min": "2.0.0",For plugins/stock-news/manifest.json:
- "ledmatrix_min_version": "2.0.0"
+ "ledmatrix_min": "2.0.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| { | |
| "released": "2026-07-17", | |
| "version": "2.8.3", | |
| "ledmatrix_min_version": "2.0.0", | |
| "notes": "Config schema reorganized for a clearer setup experience: fine-tuning fields moved behind the web UI's collapsed Advanced Settings section (x-advanced). UX-only; no fields, defaults, or behavior changed." | |
| }, | |
| { | |
| "released": "2026-07-17", | |
| "version": "2.8.3", | |
| "ledmatrix_min": "2.0.0", | |
| "notes": "Config schema reorganized for a clearer setup experience: fine-tuning fields moved behind the web UI's collapsed Advanced Settings section (x-advanced). UX-only; no fields, defaults, or behavior changed." | |
| }, |
📍 Affects 2 files
plugins/football-scoreboard/manifest.json#L27-L32(this comment)plugins/stock-news/manifest.json#L28-L33
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/football-scoreboard/manifest.json` around lines 27 - 32, Rename the
ledmatrix_min_version key to ledmatrix_min in the top changelog entry of
plugins/football-scoreboard/manifest.json (lines 27-32) and
plugins/stock-news/manifest.json (lines 28-33), without changing the associated
version, release date, or notes.
Source: Coding guidelines
…elog entries; flag soccer custom_leagues fields Renames ledmatrix_min_version to ledmatrix_min in the 12 versions[] entries this PR added (guideline key; historical entries untouched), and applies the same x-advanced flags to soccer-scoreboard's custom_leagues item fields that the 10 predefined league blocks already have. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
… overflow fix Per maintainer request, make scoreboards show content out of the box: hockey-scoreboard now defaults nhl.enabled=true and lacrosse-scoreboard defaults ncaa_mens.enabled=true, matching baseball (MLB), basketball (NBA), football (NFL) and soccer (top-5 leagues), whose primary leagues were already on. Live/Recent/Upcoming display modes were audited across all scoreboards and already default to enabled everywhere. Olympics is removed from this release: the plugin-safety harness exposed a pre-existing rendering overflow (content drawn past the right panel edge at 6 sizes) unrelated to the schema change; its x-advanced uplift will follow in a separate PR alongside an overflow fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
… it from this release Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
…efault Both plugins shipped with every league disabled, so a fresh install displayed nothing. The four major US leagues are now on by default, matching the primary-league-on convention across the scoreboards; college sports and MiLB remain opt-in. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
Contributor
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. ❌ Cannot run autofix: This PR has merge conflicts. Please resolve the conflicts with the base branch and try again. Alternatively, use |
…style elements; re-bump collided releases flights 1.12.4 and music 1.1.1 shipped on main with the same numbers this PR had used, so this PR's releases become 1.12.5 and 1.1.2 with both changelog entries preserved. of-the-day rebased onto main's 1.3.0 (x-style-elements) as 1.3.1; its x-advanced flags re-verified against the new schema. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Applies the "easy stuff up front, power stuff behind one click" treatment (LEDMatrix core PR #417's
x-advancedmechanism) to the config schemas of 31 ChuckBuilds-authored plugins, consolidated into one PR (one commit per plugin) per maintainer request. Fields a first-time user doesn't need are flagged"x-advanced": true, so the core web UI collapses them into one "Advanced Settings" section at the bottom of each plugin's config page. Schema-data change only — no field removed or renamed, norequiredchanged, no manager.py changes.Default-enable changes per maintainer request (show content out of the box): an audit confirmed the Live/Recent/Upcoming display-mode toggles already default to enabled in every scoreboard. Four plugins shipped effectively blank and now enable their primary content by default: hockey-scoreboard (
nhl.enabled: true), lacrosse-scoreboard (ncaa_mens.enabled: true), odds-ticker (NFL/NBA/MLB/NHL leagues on), and ledmatrix-leaderboard (NFL/NBA/MLB/NHL standings on) — matching baseball (MLB), basketball (NBA), football (NFL), and soccer (top-5 leagues), whose primary leagues were already on. Secondary/college leagues remain opt-in. All other defaults are untouched.Olympics was dropped from this release: the plugin-safety harness exposed a pre-existing rendering overflow in it (content drawn past the right panel edge at 6 of 8 sizes) unrelated to this schema change; its uplift will follow separately alongside an overflow fix.
Deliberately skipped:
hello-world(its 6 fields are its headline features),youtube-stats(its 5 fields are nearly all required setup), andolympics(pending overflow fix, see above). Non-ChuckBuilds plugins (7-segment-clock,ledmatrix-elections,ledmatrix-stocks,ufc-scoreboard,web-ui-info) were out of scope.Type of change
Plugin(s) affected
All 31 plugins in the table above.
Related issues
N/A — plugin-store-wide config UX uplift following LEDMatrix core PR #417. Replaces per-plugin PRs #202–#207, closed in favor of this consolidated one.
Test plan
EMULATOR=true python3 run.py)scripts/dev_server.py)For every plugin: the schema still parses as strict JSON; verified programmatically (re-run after each merge with main) that recursively stripping the added
x-advancedkeys yields a schema deep-equal to the one onmain— the only other differences anywhere are the default-enable flips in hockey / lacrosse / odds-ticker / ledmatrix-leaderboard described above; verified noobject-type property carries the flag;update_registry.pysyncedplugins.jsonfor exactly the touched plugins. The plugin-safety harness (CI "safety" job) passes for every included plugin — the earlier failure was olympics' pre-existing overflow, now dropped from the PR.Required for plugin changes
versionin each touched plugin'smanifest.json(patch bump +versions[]changelog entry withledmatrix_min,last_updatedrefreshed)class_namein each manifest matches the actual class inmanager.py(unchanged)entry_pointmatches the real file (unchanged)config_schema.jsonis the source of truth — no new options added, onlyx-advancedrender hints (+ default flips)update_registry.py;plugins.jsonmatches every bumped manifest)Checklist
CONTRIBUTING.mdCONTRIBUTING.mdandCODE_OF_CONDUCT.mdNotes for reviewer
One commit per plugin (
chore(<plugin>): …), merge commits reconciling with main, and follow-up commits addressing CodeRabbit review (ledmatrix_minkey in new changelog entries; soccercustom_leaguesfields flagged to match predefined leagues) and the maintainer's defaults request.Merges with main:
x-advancedflags re-verified against the new schema (the newcustomizationblock is a headline feature and keeps its own section, unflagged).Common patterns flagged advanced everywhere: poll/update intervals with sane defaults; per-game/per-mode dwell-time durations;
scroll_settings.*;dynamic_duration.*/mode_durations.*(off/null by default);exclude_teamsspoiler filters;favorite_live_boostrotation weighting;background_servicetimeout/retry/worker tuning;customization.*per-element font/color/pixel-offset overrides; off-by-default niche toggles; deprecated/legacy fields kept for backward compatibility.Always kept basic:
enabledtoggles, league/team/source selection (favorite_teams, credentials, coordinates, feed URLs, station IDs), show live/recent/upcoming mode toggles, top-leveldisplay_duration, primary x-widget interactions, and each plugin's headline differentiating settings.Plugin-specific notes:
custom_leaguesitem fields carry the same flags (table columns name/league_code/priority/enabled stay basic).rotation_views,data_source,skyaware_url, map center/radius stay basic.game_limits.*/display_options.*blocks confirmed in manager.py as unread legacy duplicates — demoted, left intact.enabledtoggles stay basic; per-section depth/detail knobs went advanced.customization.*.font/font_sizeare never read by manager.py — flagged; golden-image tests untouched.versions[]gap (no 2.8.2 entry) left as-is.Housekeeping: the now-obsolete per-plugin branches (
claude/chuck-builds-plugin-config-65322r-<plugin>) couldn't be deleted through this environment's git proxy — they have no open PRs and can be bulk-deleted in the GitHub UI whenever convenient.🤖 Generated with Claude Code
https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
Summary by CodeRabbit
New Features
Bug Fixes