Dropbox: return video durations and image thumbnails#11
Closed
mbyrdLCS wants to merge 1 commit into
Closed
Conversation
- list_folder now requests include_media_info so video files carry their real duration (media_info.metadata.duration -> ContentFile.seconds) - images use their shared raw link as the thumbnail (no extra API calls); videos intentionally get no duration default or thumbnail so playback apps keep the operator in control and can paint a first frame client-side Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
Note on the failing CI check: this is pre-existing breakage on main, not from this PR. Every run on main today fails identically — the apihelper workspace can't resolve @churchapps/helpers (TS2307 in src/helpers/index.ts) and the topological build stops there before reaching content-providers. This PR only touches content-providers/src/providers/dropbox; locally the package builds clean and all 21 tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dropbox provider returned no
secondsand nothumbnailon any file, so consumers (B1Admin Service Order, FreePlay) showed placeholder icons and 0:00 for everything.What changed
list_folderis now called withinclude_media_info: true, and video files mapmedia_info.metadata.duration(ms) →ContentFile.seconds. Guarded formedia_info: pending(Dropbox still processing).thumbnail— it's the same URL already being created, so zero additional API calls.urlinstead.Testing
yarn buildclean, all 21 existing tests pass🤖 Generated with Claude Code