Fleet UI: zone editor — edit zones on the map, saved as candidate revisions - #95
Merged
Conversation
The dashboard grows the review half the promote picker was missing: an 'edit zones' mode on the map canvas (drag a vertex, drag a zone, drag a pose cross, double-click to add or remove vertices, rename/add/delete in a side panel) whose save never touches the floor it edits. The server derives a new candidate from the canonical revision — same map bytes, submitted zones, vocabulary_revision bumped — via the same accept() path as a robot upload, so validation, collision handling, provenance sidecar and pruning all apply unchanged, and the promoted revision's announced digest stays backed by immutable bytes. Promotion of the edited candidate is the existing route; the browser's write surface stays operator-authenticated and audited (action map.zones). Geometry is pure functions over zones in world metres (zone_editor.mjs), tested under node beside the map transform; the editor panel carries the explicit [hidden] display guard the M3 promote picker taught us. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013o39JoxarofwaPi6kGYxXY
Saving closed the editor and re-rendered the canonical zones — the old ones, since the edits live in a candidate the map cannot preview until promotion (task 339). The operator read that as their work vanishing. finish() now freezes the saved set as the overlay, the note says the zones on screen are the candidate's, and a floor change or promotion clears the overlay since the canonical then speaks for itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013o39JoxarofwaPi6kGYxXY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard grows the review half the promote picker was missing (voro #346, P1; mapping-pipeline design stage 3): an edit zones mode on the fleet map, whose save never touches the floor it edits.
What it does
POST /v1/sites/<site>/floors/<floor>/zones(operator-authenticated, audited asmap.zones) packs the canonical revision's bytes with the submitted zones (vocabulary_revisionbumped) and feeds them through the sameaccept()path as a robot upload — validation, id-collision handling, provenance sidecar, pruning all unchanged. The canonical revision stays byte-identical, which the announced digests depend on; promotion of the edited candidate is the existing route, so the browser's write surface remains: dispatch, zone edit, promote — all audited.Testing
mote_fleet/test/test_zone_edit.py(7 tests, live server): candidate derived + listed + promotable, canonical bytes untouched, 401 without operator, 422 on structurally unreadable zones, warning (not refusal) on a name a dispatcher can't type, 409 with no published map, 400 on a non-mapping body.ui_test.mjs+7: concave point-in-polygon, vertex/edge hit-tests, insert/remove/translate/pose ops, fresh-zone naming, wire payload shape, and the[hidden]display guard (the M3 promote-picker lesson).mote_fleetsuite: 194 passed, 4 skipped (broker-gated e2e, as always).20260802T203339).Known follow-ups tracked in voro: #346 (aliases/kind, candidate-based editing, carry-forward accept/reject), #339 (candidate preview), #350 (grid snapping + shared vertices).
🤖 Generated with Claude Code
https://claude.ai/code/session_013o39JoxarofwaPi6kGYxXY