[W.I.P] Cleanroom Compute API#590
Draft
Kuba663 wants to merge 70 commits into
Draft
Conversation
Used to ensure that CR doesn't load an obsolete program binary.
This will need the command queue to work, it's late today, will work on it tomorrow. TODO: Implement invocations
Done for tests, might be replaced later
Setup tests require running the setup and that could interrupt the actual tests for OCL features like compilation, kernels, etc.
Cache uses too much stack memory. A MemoryStack would have to be created per binary. Cache will be reworked anyway so it's delayed for now.
8 tasks
Bytes don't exist apparently
They won't be used directly anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving this here because the MVP is almost ready. This is untested, I will undraft when the unit tests are done and passing. The previous PR was to the wrong branch and would have completely broken the project.
Cleanroom Compute API
Run OpenCL kernels from Cleanroom for maximum parallelism.
The goal
Have an easy to use API for running OCL code from Cleanroom, mod developers should be unable to cause memory and state leaks (if state leaks are even possible).
Code for running a kernel should look like this (as of now):
The other goal is to prevent the inferno that would break out if multiple different modders start including their own OCL jar in their mods for optimization.
Also, OpenCL supports SoA so it can work with Kirino a tad better than compute shaders which require AoS conversion.
The whole thing will use JSON files in the resources to red metadata and automatically detect headers.
TODO
MemoryStackbuffers)Look into discussion #567 for more.
Supersedes #587