Change functions that accept a JsonObject to take that as reference to const. #35936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o const. Those functions do not change the object, they just read values from it. This avoid unnecessary copy-operations and allows usage of temporary objects (which don't bind to non-const references).
ifreund
added
[C++]
Error reporting functions are public and can be called on any object, even on those that do not have an associated stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of what is currently done: either those functions accept a value (a copy of the argument, which means overhead) or a non-const value, which means one can't use a temporary object.
SUMMARY: None