Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(done) House basements 1 (house04, 05, 06, 07, quiverfull, and library) #36707

Merged
merged 12 commits into from
Jan 10, 2020

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Jan 5, 2020

Summary

SUMMARY: Content "Adds stair/footprint matched basements to some houses"

Purpose of change

@curstwist has been going around adding roofs to old house JSON maps and renovating them. These houses still do not have staircase matching to the basements. Eventually we want to eliminate the code that lets you teleport when you go down stairs, so we'll need to make staircases align. Plus, the old basements are just not that great.

Describe the solution

Adds matched basements to existing house plans. Also adds some useful nested maps like offices.

This adds a basic basement with randomized nested mapgen including a home office, a toilet, some bedrooms, a utility room, and a rec room / living room.

Describe alternatives you've considered

I don't have to get all up in the nested maps but I am bad at doing things quickly.

Testing

image
Final version, with rotation and monster spawns

image
image
image

Additional Context

I will make a follow-up PR with some more varied floorplans, at least an unfinished basement being used for storage. I'd like to add a basement that works as a secondary suite as well, but that's tough without the ability to modify the level above, so it'll wait for more sophisticated nested map management probably.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 5, 2020
@curstwist
Copy link
Contributor

looking great so far!

@I-am-Erk I-am-Erk changed the title WIP: House basements 1 House basements 1 (house04, 05, 06, 07, quiverfull, and library) Jan 7, 2020
@I-am-Erk I-am-Erk marked this pull request as ready for review January 7, 2020 05:48
@I-am-Erk I-am-Erk changed the title House basements 1 (house04, 05, 06, 07, quiverfull, and library) (done) House basements 1 (house04, 05, 06, 07, quiverfull, and library) Jan 9, 2020
@AskaHope
Copy link

AskaHope commented Jan 9, 2020

Do you intend to set fixed tiles for stairs? To prevent things like stairs spawning adjacent to toilets?

@I-am-Erk
Copy link
Member Author

I-am-Erk commented Jan 9, 2020

I think you're a bit confused about how stairs work, but yes that's one of the bugs this addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants