reweight gemstones in item_groups.json #36734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Summary ```SUMMARY: Content "reweight gemstones in item_groups.json"``` #### Purpose of change Diamonds and pearls are more commonly worn gemstones in New England. #### Describe the solution The item group is subtype is not defined. Therefore it defaults to old, which works as a distribution. The item_group previously had each item weighted 50. All were equally likely. I&CleverRaven#39;ve changed diamond and pearl to 100. So now the probability is: * diamond: 12.5% * pearl: 12.5% * any other: 75% #### Describe alternatives you've considered I considered making emeralds less common due to their rarity, but I couldn&CleverRaven#39;t determine an appropriate ratio. #### Testing None! I did this through github in the browser so no testing was done. #### Additional context I want to add turquoise to the table too, but I figured there might be a good reason why this common gemstone was left off.
curstwist
added
[JSON]
|
I also modified a comment to make it easier to specify which file the SUS_fridge item group is in. |
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Jan 7, 2020
reweight gemstones in item_groups.json (CleverRaven#36734)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "reweight gemstones in item_groups.json"Purpose of change
Diamonds and pearls are more commonly worn gemstones in New England.
Describe the solution
The item group is subtype is not defined. Therefore it defaults to old, which works as a distribution.
The item_group previously had each item weighted 50. All were equally likely.
I've changed diamond and pearl to 100. So now the probability is:
Describe alternatives you've considered
I considered making emeralds less common due to their rarity, but I couldn't determine an appropriate ratio.
Testing
None! I did this through github in the browser so no testing was done.
Additional context
I want to add turquoise to the table too, but I figured there might be a good reason why this common gemstone was left off.
I also modified a comment to make it easier to specify which file the SUS_fridge item group is in.