Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxpack #36746

Merged
merged 7 commits into from
Jan 8, 2020
Merged

Boxpack #36746

merged 7 commits into from
Jan 8, 2020

Conversation

k4gi
Copy link
Contributor

@k4gi k4gi commented Jan 6, 2020

Summary

SUMMARY: Content "Adds new wooden box backpack"

Describe the solution

I present for your consideration, a wooden box you can strap to your back! I copied some stats from the wooden frame and jerrypack.

Describe alternatives you've considered

None

Testing

I've spawned some items in to make sure the item and recipe are as i expected.

2020-01-06_12:48:06_+1100_screencut

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 6, 2020
@8street
Copy link
Contributor

8street commented Jan 6, 2020

To make a box, you must also use a saw, in my opinion.

@k4gi
Copy link
Contributor Author

k4gi commented Jan 6, 2020

To make a box, you must also use a saw, in my opinion.

quite possibly! but this is not the case for the wooden frame, or the box you can install to a vehicle with one

uh also what do i do about "The Travis CI build failed"

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely needs a saw. Not having that in the other recipes is a sign that they need fixing, not that this doesn't need it.

Also a good case for some wood panels, making a box entirely out of large planks isn't reasonable.

data/json/recipes/armor/storage.json Outdated Show resolved Hide resolved
data/json/recipes/armor/storage.json Outdated Show resolved Hide resolved
data/json/recipes/armor/storage.json Outdated Show resolved Hide resolved
k4gi and others added 3 commits January 8, 2020 10:25
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
@k4gi
Copy link
Contributor Author

k4gi commented Jan 7, 2020

seems good to me !

@k4gi k4gi requested a review from I-am-Erk January 7, 2020 23:34
@I-am-Erk I-am-Erk merged commit 29351f0 into CleverRaven:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants