Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragon skin changes #36861

Closed

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Jan 10, 2020

Changed dragon skin armor to better match its real life counterpart.

Summary

SUMMARY: Balance "Rebalances dragon skin to better fit its real life counterpart"

Purpose of change

Changes dragon skin armor to be a heavier, slightly less protective, and non sturdy variant of the mbr (ceramic plates).
Before this it was a lightweight, low encumbrance, outer vest. one of the best pieces of armor in the game. It should be similar to, but not as good, as the military version of the same thing, as it is in real life.

Describe the solution

Increase it's weight and encumbrance, increase it's armor values. remove the sturdy flag. Change the flavor text.

Describe alternatives you've considered

Removing dragon skin armor from the game.
Leaving dragon skin as it is, which is different from what you would expect in real life.
Matching i's weight and performance as exactly as possible to its real life performance rather than fitting it into the current armor system.

Testing

Spawned the armor, checked that it's values were all correct, wore the armor, spawned some zombies to check for weird interactions.

Additional context

image
Additionally, this PR should not be merged before #36853 , because it should make the armor a weaker version of the mbr(ceramic plates) found in that PR. If that PR is closed i can adjust this one so the armor values are slightly below the old mbr vest.

Changed dragon skin armor to better match it's real life counterpart.
@tenmillimaster
Copy link
Member

Due to the lack of popularity of dragonskin, and the incredible amounts of controversy that its testing sparked, I'd argue for just outright dropping dragonskin, or relegating it to meme status. There's not enough test data to show how resilient it's supposed to be, or how it really stacks up to multiple hits.

All of it is well out of the 6 year warranty period anyways.

@arijust
Copy link
Contributor

arijust commented Jan 10, 2020

Sometimes realism in video games gets too far.
It's one of these moments.

@Brian-Otten
Copy link
Contributor Author

I'll just start a small poll here for convenience then since i'm fine with the other options as well:
Rebalance dragon skin = heart
Remove dragon skin = thumbs down
Keep as is = thumbs up

@tenmillimaster
Copy link
Member

tenmillimaster commented Jan 10, 2020

Changes and commits are not implemented based on user input. Polls have no meaning.

https://discourse.cataclysmdda.org/t/fms-frequently-made-suggestions/9764/4

@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Jan 10, 2020

No, but they can give you some idea of what people want which can be useful. The ultimate decision as always remains up to the maintainers of the project, which is for the best.

@Brian-Otten
Copy link
Contributor Author

So got some feedback from the discord that it would probably be best to just keep this one 100% realism based, if we do the weight would go to 21.5 kg, and according to army tests it "sometimes" stops rifle rounds, and where exactly that puts it's armor value is debatable.
I could try and adjust the armor some so it fits those values, but it would probably go unused by all survivors so i think we might want to remove it at that point.
some fun trivia reading on dragonskin armor:
http://www.nbcnews.com/id/18790506/ns/us_news-military/t/army-dragon-skin-armor-failed-battery-tests/
https://archive.defense.gov/DODCMSShare/briefingslide/304/070521-D-6570C-001.pdf

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 10, 2020
@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 10, 2020

I suspect this was added around the time the armour was getting some press, because it sounds cool. It's rare, it's arguably not significantly different from other plate-based bulletproof vests, the company that makes it is belly-up IRL so no more is getting made, and we can't get good use statistics on it. I don't think there's any argument for keeping it. Just give it a migration flag to mbr with ceramic plates or another similar armour type.

@Brian-Otten
Copy link
Contributor Author

Sounds good to me, will close this and open an issue to migrate dragon skin into a suitable replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants