Try shmem restore branch

[charleskawczynski]

No description provided.

[gemini-code-assist]

Hello @charleskawczynski, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request appears to be an attempt to incorporate changes from the ck/restore_fd_shmem branch of the CliMA/ClimaCore.jl repository. The changes modify the .buildkite/Manifest-v1.11.toml file to update the project hash and specify a custom repository URL and revision for the ClimaCore dependency. This suggests an effort to test or integrate specific, potentially unreleased, features or fixes from that branch into the current environment.

Highlights

• Dependency Update: The pull request updates the ClimaCore dependency in the Manifest-v1.11.toml file to point to a specific branch (ck/restore_fd_shmem) in the CliMA/ClimaCore.jl repository.
• Project Hash Update: The pull request updates the project hash in Manifest-v1.11.toml from dbb001c3c134c9962d9a283b94c060c2d2eb8b6a to 04945e2a7116cfacb2d57340f477dbe23e208227.

Changelog

• .buildkite/Manifest-v1.11.toml
  • Updated project hash from dbb001c3c134c9962d9a283b94c060c2d2eb8b6a to 04945e2a7116cfacb2d57340f477dbe23e208227.
  • Added repo-rev = "ck/restore_fd_shmem" to the ClimaCore dependency.
  • Added repo-url = "https://github.com/CliMA/ClimaCore.jl.git" to the ClimaCore dependency.
  • Updated git-tree-sha1 for ClimaCore from 302ac45b7e534f3067a889f6a7487b5301063c78 to 221c96ae9ea9c2453c72ee471fabfff7e4c0e628.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

The SHA-1 algorithm, used for generating the git-tree-sha1 values, is now considered cryptographically broken and has been replaced by SHA-256 in many applications.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the Manifest-v1.11.toml file to reflect changes in the ClimaCore dependency. Specifically, it updates the project_hash and git-tree-sha1, and adds repo-rev and repo-url. This seems to be related to restoring shared memory functionality. The changes appear straightforward.

Summary of Findings

• Dependency Update Verification: It's important to verify that the updated project_hash and git-tree-sha1 values are correct and correspond to the intended version of ClimaCore with the ck/restore_fd_shmem branch. This ensures that the correct code is being used.
• Impact Assessment: Assess the impact of using the ck/restore_fd_shmem branch of ClimaCore on the overall ClimaAtmos project. Consider potential compatibility issues or performance implications.

Merge Readiness

The changes seem reasonable, but it's crucial to verify the correctness of the updated dependency information and assess the potential impact of using a specific branch of ClimaCore. I am unable to approve this pull request, and recommend that it not be merged until the dependency update has been verified, and the impact of the ClimaCore ck/restore_fd_shmem branch has been assessed. Another reviewer should approve this code before merging.

[gemini-code-assist]

medium: Verify that this git-tree-sha1 corresponds to the ck/restore_fd_shmem branch of ClimaCore. It's crucial to ensure that the correct commit is being used.

[gemini-code-assist]

medium: Adding repo-rev and repo-url provides useful context. Consider adding a comment explaining why this specific branch is being used and any potential implications for the stability or compatibility of ClimaAtmos.

[charleskawczynski]

This is now fixed.