Logical error: 'Table with storage id default.t0 (...) already registered' with S3Queue

[PedroTadim]

Describe the bug

Easy to reproduce. The same happens with AzureQueue.

How to reproduce

Run:

CREATE TABLE t0 (c0 Int) ENGINE = S3Queue('...minio bucket.../file0/', 'user', 'password', CSV) SETTINGS mode = 'unordered';
DETACH TABLE t0 SYNC;
ATTACH TABLE t0; --Logical Error

Error message and/or stacktrace

Stack trace:

<Fatal> : Logical error: 'Table with storage id default.t0 (15bcb0e8-3a50-41d0-bc39-4de4201c87f9) already registered'.
<Fatal> : Stack trace (when copying this message, always include the lines below):

0. contrib/llvm-project/libcxx/include/__exception/exception.h:113: Poco::Exception::Exception(String const&, int) @ 0x00000000265358f2
1. src/Common/Exception.cpp:115: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x0000000014076fe6
2. src/Common/Exception.h:119: DB::Exception::Exception(PreformattedMessage&&, int) @ 0x000000000cd6a5ac
3. src/Common/Exception.h:137: DB::Exception::Exception<String>(int, FormatStringHelperImpl<std::type_identity<String>::type>, String&&) @ 0x000000000cd6a236
4. src/Storages/ObjectStorageQueue/ObjectStorageQueueMetadataFactory.cpp:37: DB::ObjectStorageQueueFactory::registerTable(DB::StorageID const&) @ 0x000000001e29d767
5. src/Storages/ObjectStorageQueue/StorageObjectStorageQueue.cpp:267: DB::StorageObjectStorageQueue::startup() @ 0x000000001e3287ef
6. src/Interpreters/InterpreterCreateQuery.cpp:2039: DB::InterpreterCreateQuery::doCreateTable(DB::ASTCreateQuery&, DB::InterpreterCreateQuery::TableProperties const&, std::unique_ptr<DB::DDLGuard, std::default_delete<DB::DDLGuard>>&, DB::LoadingStrictnessLevel) @ 0x000000001aee5a7d
7. src/Interpreters/InterpreterCreateQuery.cpp:1752: DB::InterpreterCreateQuery::createTable(DB::ASTCreateQuery&) @ 0x000000001aede7ac
8. src/Interpreters/InterpreterCreateQuery.cpp:2362: DB::InterpreterCreateQuery::execute() @ 0x000000001aeeb592
9. src/Interpreters/executeQuery.cpp:1561: DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*, std::shared_ptr<DB::IAST>&, std::shared_ptr<DB::ImplicitTransactionControlExecutor>) @ 0x000000001b27b243
10. src/Interpreters/executeQuery.cpp:1769: DB::executeQuery(String const&, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum) @ 0x000000001b2751bb
11. src/Server/TCPHandler.cpp:723: DB::TCPHandler::runImpl() @ 0x000000001e4fb492
12. src/Server/TCPHandler.cpp:2724: DB::TCPHandler::run() @ 0x000000001e514c24
13. base/poco/Net/src/TCPServerConnection.cpp:40: Poco::Net::TCPServerConnection::start() @ 0x00000000265eb9c7
14. base/poco/Net/src/TCPServerDispatcher.cpp:115: Poco::Net::TCPServerDispatcher::run() @ 0x00000000265ebfa5
15. base/poco/Foundation/src/ThreadPool.cpp:205: Poco::PooledThread::run() @ 0x000000002658b93f
16. base/poco/Foundation/src/Thread_POSIX.cpp:341: Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000026589011
17. start_thread @ 0x00000000000a27f1
18. __clone3 @ 0x0000000000133c9c

[colatkinson]

I've recently started getting the same error on CH Cloud 25.4 when doing a CREATE OR REPLACE TABLE ... ENGINE = S3Queue. Does it seem likely this is the same issue, or unrelated?

Traceback for reference:

  DB::Exception: Table with storage id [redacted].[redacted] (bb2af479-f938-480e-bff2-9f157eaa5601) is already registered. Stack trace:

  0. ./ci/tmp/build/./src/Common/Exception.cpp:112: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000d529e08
  1. DB::Exception::Exception(PreformattedMessage&&, int) @ 0x0000000009182e3c
  2. DB::Exception::Exception<String>(int, FormatStringHelperImpl<std::type_identity<String>::type>, String&&) @ 0x0000000009182b98
  3. ./ci/tmp/build/./src/Storages/ObjectStorageQueue/ObjectStorageQueueMetadataFactory.cpp:72: DB::ObjectStorageQueueFactory::renameTable(DB::StorageID const&, DB::StorageID const&) @ 0x00000000125686b8
  4. ./ci/tmp/build/./src/Storages/ObjectStorageQueue/StorageObjectStorageQueue.cpp:312: DB::StorageObjectStorageQueue::renameInMemory(DB::StorageID const&) @ 0x00000000125defdc
  5. ./ci/tmp/build/./src/Databases/DatabaseAtomic.cpp:335: DB::DatabaseAtomic::renameTable(std::shared_ptr<DB::Context const>, String const&, DB::IDatabase&, String const&, bool, bool) @ 0x000000001050c7e0
  6. ./ci/tmp/build/./src/Databases/DatabaseReplicated.cpp:1856: DB::DatabaseReplicated::renameTable(std::shared_ptr<DB::Context const>, String const&, DB::IDatabase&, String const&, bool, bool) @ 0x0000000010565cdc
  7. ./ci/tmp/build/./src/Interpreters/InterpreterRenameQuery.cpp:186: DB::InterpreterRenameQuery::executeToTables(DB::ASTRenameQuery const&, std::vector<DB::RenameDescription, std::allocator<DB::RenameDescription>> const&, std::map<DB::UniqueTableName, std::unique_ptr<DB::DDLGuard, std::default_delete<DB::DDLGuard>>, std::less<DB::UniqueTableName>, std::allocator<std::pair<DB::UniqueTableName const, std::unique_ptr<DB::DDLGuard, std::default_delete<DB::DDLGuard>>>>>&) @ 0x000000001103bd74
  8. ./ci/tmp/build/./src/Interpreters/InterpreterRenameQuery.cpp:91: DB::InterpreterRenameQuery::execute() @ 0x00000000110393f4
  9. ./ci/tmp/build/./src/Interpreters/InterpreterCreateQuery.cpp:2576: DB::InterpreterCreateQuery::doCreateOrReplaceTable(DB::ASTCreateQuery&, DB::InterpreterCreateQuery::TableProperties const&, DB::LoadingStrictnessLevel) @ 0x0000000010ff5534
  10. ./ci/tmp/build/./src/Interpreters/InterpreterCreateQuery.cpp:1937: DB::InterpreterCreateQuery::createTable(DB::ASTCreateQuery&) @ 0x0000000010fee254
  11. ./ci/tmp/build/./src/Interpreters/InterpreterCreateQuery.cpp:2763: DB::InterpreterCreateQuery::execute() @ 0x0000000010fde05c
  12. ./ci/tmp/build/./src/Interpreters/executeQuery.cpp:1499: DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*, std::shared_ptr<DB::IAST>&) @ 0x0000000011402ef0
  13. ./ci/tmp/build/./src/Interpreters/executeQuery.cpp:1832: DB::executeQuery(DB::ReadBuffer&, DB::WriteBuffer&, bool, std::shared_ptr<DB::Context>, std::function<void (DB::QueryResultDetails const&)>, DB::QueryFlags, std::optional<DB::FormatSettings> const&, std::function<void (DB::IOutputFormat&, String const&, std::shared_ptr<DB::Context const> const&, std::optional<DB::FormatSettings> const&)>) @ 0x0000000011406b0c
  14. ./ci/tmp/build/./src/Interpreters/DDLWorker.cpp:510: DB::DDLWorker::tryExecuteQuery(DB::DDLTaskBase&, std::shared_ptr<zkutil::ZooKeeper> const&, bool) @ 0x0000000010f11950
  15. ./ci/tmp/build/./src/Interpreters/DDLWorker.cpp:675: DB::DDLWorker::processTask(DB::DDLTaskBase&, std::shared_ptr<zkutil::ZooKeeper> const&, bool) @ 0x0000000010f10158
  16. ./ci/tmp/build/./src/Databases/DatabaseReplicatedWorker.cpp:416: DB::DatabaseReplicatedDDLWorker::tryEnqueueAndExecuteEntry(DB::DDLLogEntry&, std::shared_ptr<DB::Context const>, bool) @ 0x000000001057a3dc
  17. ./ci/tmp/build/./src/Databases/DatabaseReplicated.cpp:1149: DB::DatabaseReplicated::tryEnqueueReplicatedDDL(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context const>, DB::QueryFlags) @ 0x0000000010553448
  18. ./ci/tmp/build/./src/Interpreters/InterpreterCreateQuery.cpp:1905: DB::InterpreterCreateQuery::createTable(DB::ASTCreateQuery&) @ 0x0000000010fee4f0
  19. ./ci/tmp/build/./src/Interpreters/InterpreterCreateQuery.cpp:2763: DB::InterpreterCreateQuery::execute() @ 0x0000000010fde05c
  20. ./ci/tmp/build/./src/Interpreters/executeQuery.cpp:1499: DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*, std::shared_ptr<DB::IAST>&) @ 0x0000000011402ef0
  21. ./ci/tmp/build/./src/Interpreters/executeQuery.cpp:1690: DB::executeQuery(String const&, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum) @ 0x00000000113fdc64
  22. ./ci/tmp/build/./src/Server/TCPHandler.cpp:684: DB::TCPHandler::runImpl() @ 0x00000000127d5300
  23. ./ci/tmp/build/./src/Server/TCPHandler.cpp:2688: DB::TCPHandler::run() @ 0x00000000127f0e68
  24. ./src/Server/TCPProtocolStackHandler.h:38: DB::TCPProtocolStackHandler::run() @ 0x000000000d84eff4
  25. ./ci/tmp/build/./base/poco/Net/src/TCPServerConnection.cpp:40: Poco::Net::TCPServerConnection::start() @ 0x00000000157ecf98
  26. ./ci/tmp/build/./base/poco/Net/src/TCPServerDispatcher.cpp:115: Poco::Net::TCPServerDispatcher::run() @ 0x00000000157ed4b4
  27. ./ci/tmp/build/./base/poco/Foundation/src/ThreadPool.cpp:205: Poco::PooledThread::run() @ 0x00000000157b085c
  28. ./base/poco/Foundation/src/Thread_POSIX.cpp:335: Poco::ThreadImpl::runnableEntry(void*) @ 0x00000000157aec30
  29. ? @ 0x000000000007d5b8
  30. ? @ 0x00000000000e5edc

[kssenii]

@colatkinson thank you for reporting, I will fix it in #84677 as well and backport to all affected versions, which should be this week.