Logical error: 'Part minmax index by time is neither DateTime or DateTime64'

[PedroTadim]

Describe the bug

I am playing with probabilities, so this may not be easy to reproduce in the CI. It has been happening for a long time.

How to reproduce

Run Fiddle: https://fiddle.clickhouse.com/b681de49-68fe-4c5d-8fdc-75baabf7d4ec

Error message and/or stacktrace

Stack trace:

<Fatal> : Logical error: 'Part minmax index by time is neither DateTime or DateTime64'.
<Fatal> : Format string: 'Part minmax index by time is neither DateTime or DateTime64'.
<Fatal> : Stack trace (when copying this message, always include the lines below):

0. contrib/llvm-project/libcxx/include/__exception/exception.h:113: Poco::Exception::Exception(String const&, int) @ 0x00000000263c9632
1. src/Common/Exception.cpp:136: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x0000000016174369
2. src/Common/Exception.h:172: DB::Exception::Exception(String&&, int, String, bool) @ 0x000000000d7c2754
3. src/Common/Exception.h:58: DB::Exception::Exception(PreformattedMessage&&, int) @ 0x000000000d7c2251
4. src/Common/Exception.h:190: DB::Exception::Exception<>(int, FormatStringHelperImpl<>) @ 0x000000001617cdb9
5. src/Storages/MergeTree/IMergeTreeDataPart.cpp:594: DB::IMergeTreeDataPart::getMinMaxTime() const @ 0x000000001f709be7
6. src/Storages/System/StorageSystemParts.cpp:222: DB::StorageSystemParts::processNextStorage(std::shared_ptr<DB::Context const>, std::vector<COW<DB::IColumn>::mutable_ptr<DB::IColumn>, std::allocator<COW<DB::IColumn>::mutable_ptr<DB::IColumn>>>&, std::vector<char8_t, std::allocator<char8_t>>&, DB::StoragesInfo const&, bool) @ 0x0000000018930c85
7. src/Storages/System/StorageSystemPartsBase.cpp:331: DB::ReadFromSystemPartsBase::initializePipeline(DB::QueryPipelineBuilder&, DB::BuildQueryPipelineSettings const&) @ 0x0000000018938767
8. src/Processors/QueryPlan/ISourceStep.cpp:20: DB::ISourceStep::updatePipeline(std::vector<std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>, std::allocator<std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>>>, DB::BuildQueryPipelineSettings const&) @ 0x000000002061b259
9. src/Processors/QueryPlan/QueryPlan.cpp:209: DB::QueryPlan::buildQueryPipeline(DB::QueryPlanOptimizationSettings const&, DB::BuildQueryPipelineSettings const&, bool) @ 0x000000002065bc6f
10. src/Interpreters/InterpreterSelectQueryAnalyzer.cpp:375: DB::InterpreterSelectQueryAnalyzer::buildQueryPipeline() @ 0x000000001c4506f9
11. src/Interpreters/InterpreterSelectQueryAnalyzer.cpp:340: DB::InterpreterSelectQueryAnalyzer::execute() @ 0x000000001c4502dc
12. src/Interpreters/executeQuery.cpp:1748: DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, std::unique_ptr<DB::ReadBuffer, std::default_delete<DB::ReadBuffer>>&, std::shared_ptr<DB::IAST>&, std::shared_ptr<DB::ImplicitTransactionControlExecutor>, std::function<void ()>, DB::QueryResultDetails&) @ 0x000000001c7a8be8
13. src/Interpreters/executeQuery.cpp:1972: DB::executeQuery(String const&, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum) @ 0x000000001c7a2354
14. src/Server/TCPHandler.cpp:774: DB::TCPHandler::runImpl() @ 0x000000001ffeb509
15. src/Server/TCPHandler.cpp:2862: DB::TCPHandler::run() @ 0x0000000020006524
16. base/poco/Net/src/TCPServerConnection.cpp:40: Poco::Net::TCPServerConnection::start() @ 0x000000002647e00e
17. base/poco/Net/src/TCPServerDispatcher.cpp:115: Poco::Net::TCPServerDispatcher::run() @ 0x000000002647e67b
18. base/poco/Foundation/src/ThreadPool.cpp:205: Poco::PooledThread::run() @ 0x000000002641eb7f
19. base/poco/Foundation/src/Thread_POSIX.cpp:341: Poco::ThreadImpl::runnableEntry(void*) @ 0x000000002641c20f
20. ? @ 0x00000000000a3d64
21. __clone3 @ 0x00000000001373bc

[ashrithb]

Hey @PedroTadim! I've been looking at this issue and have been able to reproduce it locally, and have also found what I think is the cause and fix for this issue, would you mind assigning it to me?

[ashrithb]

Feel free to check out my PR I made for this @PedroTadim, let me know if you have any questions!