Fix local server crash on CREATE DICTIONARY with bogus definition.#100036
Fix local server crash on CREATE DICTIONARY with bogus definition.#100036yakov-olkhovskiy merged 2 commits intomasterfrom
Conversation
|
Workflow [PR], commit [439aa5e] Summary: ✅ AI ReviewSummaryThis PR fixes a null dereference in Missing context
ClickHouse Rules
Final Verdict
|
clickhouse-gh
Bot
added
the
pr-bugfix
evillique
left a comment
evillique
left a comment
There was a problem hiding this comment.
Should we add a simple one-line SQL test?
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
…unction The existing test 03290_dictionary_assert_on_function.sql runs against clickhouse-server where the early `isServerCompletelyStarted` check fires before reaching the null-pointer dereference. This new test exercises the fix through clickhouse-local, where the application type is LOCAL (not SERVER), so the early check is skipped and the new null-check code path in `buildConfigurationFromFunctionWithKeyValueArguments` is exercised. Ref: #100036 Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…unction The existing test 03290_dictionary_assert_on_function.sql runs against clickhouse-server where the early `isServerCompletelyStarted` check fires before reaching the null-pointer dereference. This new test exercises the fix through clickhouse-local, where the application type is LOCAL (not SERVER), so the early check is skipped and the new null-check code path in `buildConfigurationFromFunctionWithKeyValueArguments` is exercised. Ref: #100036 Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
yeah, delegated it to AI :) |
|
|
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 80.00% (8/10, 0 noise lines excluded) |
|
Hi @yakov-olkhovskiy @evillique — while reviewing this PR I found the following:
Happy to discuss — close anything that's wrong or already addressed. |
6 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix local server crash when CREATE DICTIONARY has a definition with list value containing non-existing function.
closes #99995