Fix Nullable(Tuple) not working with CSV, MsgPack format properly#100038
Merged
Avogar merged 8 commits intoClickHouse:masterfrom Mar 19, 2026
Merged
Fix Nullable(Tuple) not working with CSV, MsgPack format properly#100038Avogar merged 8 commits intoClickHouse:masterfrom
Nullable(Tuple) not working with CSV, MsgPack format properly#100038Avogar merged 8 commits intoClickHouse:masterfrom
Conversation
Contributor
Contributor
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 97.50% (39/40, 0 noise lines excluded) |
Avogar
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given,
CSV:
MsgPack:
This PR contains test for other formats as well to make sure they work with empty
Nullable(Tuple).TODO: Currently, Arrow, ArrowStream, and ORC still have problem with
Nullable(Tuple)which I will fix later in subsequent PR.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix
CSV,MsgPackformat not being able to parseNullable(Tuple)properly. Closes #99753.Documentation entry for user-facing changes