Fix LowCardinality(Nullable(T)) query parameters not defaulting to NULL when omitted#100144
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Mar 20, 2026
Merged
Conversation
LowCardinality(Nullable(T)) query parameters not defaulting to NULL when omittedLowCardinality(Nullable(T)) query parameters not defaulting to NULL when omitted
alexey-milovidov
approved these changes
Mar 19, 2026
Contributor
|
Workflow [PR], commit [89161a9] Summary: ✅ AI ReviewSummaryThis PR fixes omitted query parameters for ClickHouse Rules
Final VerdictStatus: ✅ Approve |
Contributor
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 100.00% (5/5, 0 noise lines excluded) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #93869 added support for omitted
Nullable(T)query parameters defaulting to NULL, but usedisNullable()which returnsfalseforLowCardinality(Nullable(T)).Changed to
isNullableOrLowCardinalityNullableto cover both cases.Closes #99805
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Omitted query parameters with
LowCardinality(Nullable(T))type now correctly default to NULL, same asNullable(T).Documentation entry for user-facing changes