Disable AI SQL generation in embedded client

[alexey-milovidov]

The embedded client (used by SSH and WebSocket terminal protocols) runs inside the server process. The initAIProvider function reads API keys from environment variables (OPENAI_API_KEY, ANTHROPIC_API_KEY), which is a security concern since the server's environment should not be exposed to connected users via the ?? command.

Skip initAIProvider when isEmbeeddedClient returns true, both in interactive and non-interactive mode paths. The ?? command will print "AI SQL generator is not initialized" instead of accessing environment variables.

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Disable AI SQL generation (?? command) in the embedded client (SSH and WebSocket protocols) to prevent access to the server's environment variables.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

[clickhouse-gh]

Workflow [PR], commit [8c86dd9]

Summary: ✅

---

AI Review

Summary

This PR disables initAIProvider in embedded client mode (SSH and WebSocket terminal protocols) in both interactive and non-interactive paths, preventing access to AI provider credentials from the server environment. The change is minimal, targeted, and consistent with existing embedded-mode restrictions in ClientBase. I found no correctness, safety, performance, or compatibility issues in the patch.

ClickHouse Rules

Item	Status	Notes
Deletion logging	➖
Serialization versioning	➖
Core-area scrutiny	✅
No test removal	✅
Experimental gate	➖
No magic constants	✅
Backward compatibility	✅
SettingsChangesHistory.cpp	➖
PR metadata quality	✅
Safe rollout	✅
Compilation time	✅
No large/binary files	✅

Final Verdict

• Status: ✅ Approve

[alexey-milovidov]

#100299

[alexey-milovidov]

#100378

[alexey-milovidov]

The Stress test (arm_msan) failure is fixed by #101239, which should be merged first. After it is merged, please update the branch to include the fix.

[clickhouse-gh]

LLVM Coverage Report

Metric	Baseline	Current	Δ
Lines	84.00%	84.10%	+0.10%
Functions	90.90%	90.90%	+0.00%
Branches	76.60%	76.50%	-0.10%

Changed lines: 100.00% (11/11) | lost baseline coverage: 1 line(s) · Uncovered code

Full report · Diff report

[alexey-milovidov]

Thanks for the review. It was not easy, but we made it!

[alexey-milovidov]

Now please review #100277