Skip to content

fix missing spaces when formatting unlock snapshot#102063

Merged
hanfei1991 merged 3 commits intoClickHouse:masterfrom
hanfei1991:hanfei/fix-missing-spaces
Apr 13, 2026
Merged

fix missing spaces when formatting unlock snapshot#102063
hanfei1991 merged 3 commits intoClickHouse:masterfrom
hanfei1991:hanfei/fix-missing-spaces

Conversation

@hanfei1991
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

fix missing spaces when formatting unlock snapshot. close #101723

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Apr 8, 2026

Workflow [PR], commit [b7d34d5]

Summary:

job_name test_name status info comment
Unit tests (tsan) failure
FunctionsStress.stress failure cidb
AllTests failure cidb

AI Review

Summary

This PR fixes SQL formatter output for UNLOCK SNAPSHOT by adding missing spaces in two formatter paths (ALTER ... UNLOCK SNAPSHOT and SYSTEM UNLOCK SNAPSHOT) and adds a stateless test covering both statements. I did not find correctness, safety, performance, or compatibility issues in the patch.

ClickHouse Rules
Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality
Safe rollout
Compilation time
No large/binary files
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh Bot added the pr-bugfix Pull request with bugfix, not backported by default label Apr 8, 2026
@evillique evillique self-assigned this Apr 9, 2026
@alexey-milovidov
Copy link
Copy Markdown
Member

The flaky check failure is fixed in #102148, let's update the branch.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Apr 12, 2026

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.00% 84.00% +0.00%
Functions 90.80% 90.90% +0.10%
Branches 76.50% 76.50% +0.00%

Changed lines: 92.86% (13/14) | lost baseline coverage: 2 line(s) · Uncovered code

Full report · Diff report

@hanfei1991 hanfei1991 added this pull request to the merge queue Apr 13, 2026
Merged via the queue into ClickHouse:master with commit 694c789 Apr 13, 2026
162 of 164 checks passed
@hanfei1991 hanfei1991 deleted the hanfei/fix-missing-spaces branch April 13, 2026 12:20
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UNLOCK SNAPSHOT formatting missing spaces in both ALTER and SYSTEM variants

4 participants