Added Parquet Shredded VARIANT Support to ParquetReaderv3#102499
Open
rorylshanks wants to merge 109 commits intoClickHouse:masterfrom
Open
Added Parquet Shredded VARIANT Support to ParquetReaderv3#102499rorylshanks wants to merge 109 commits intoClickHouse:masterfrom
rorylshanks wants to merge 109 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [4b822ff] Summary: ⏳
AI ReviewSummaryThis PR adds Parquet ClickHouse Rules
Final Verdict
|
…compilation warning
Member
|
Thanks for the contribution. Really cool. |
…ng. Alsofixed issues in prewhere/header plumbing for typed JSON subcolumns.
1 task
1 task
Contributor
LLVM Coverage Report
Changed lines: 58.25% (3971/6817) | lost baseline coverage: 25 line(s) · Uncovered code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the parquet Shredded VARIANT standard to CLickHouse. duckdb has this already and the main benefit is that it can read less bytes from disk. This is of course critical for a main parquet use case, which is remote reads from S3.
Benchmark results for JSONBench reading from file() on NVME on the final binary are below.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Add Parquet shredded VARIANT support, including read/write paths and subcolumn-aware read optimizations for semi-structured data.
Documentation entry for user-facing changes