Skip to content

Bump chdig to v26.4.3#103145

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:chdig-v26.4.3
Apr 20, 2026
Merged

Bump chdig to v26.4.3#103145
azat merged 1 commit intoClickHouse:masterfrom
azat:chdig-v26.4.3

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Apr 20, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

chdig to v26.4.3 (perfetto improvements, fixes for sharing via pastila.nl, flamegraph diffs, change settings in realtime)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Apr 20, 2026

Workflow [PR], commit [f33d7c5]

Summary:

job_name test_name status info comment
Upgrade check (amd_release) FAIL
Error message in clickhouse-server.log (see upgrade_error_messages.txt) FAIL cidb

AI Review

Summary

This PR updates chdig/Rust vendoring pointers and refreshes the related Cargo.lock dependency set for v26.4.3. The code changes themselves look consistent for a dependency bump, but there is one user-facing metadata issue in the PR description: the changelog entry claims v26.4.3 while linking to the v26.4.1 release page.

PR Metadata
  • Changelog category: Improvement is acceptable for this dependency/version bump.
  • Changelog entry: present and required for this category, but currently inconsistent (v26.4.3 text links to v26.4.1).
  • Replacement text:
    • chdig to [v26.4.3](https://github.com/azat/chdig/releases/tag/v26.4.3) (perfetto improvements, fixes for sharing via pastila.nl, flamegraph diffs, change settings in realtime)
Findings

💡 Nits

  • [contrib/chdig:1] PR metadata inconsistency: changelog text says v26.4.3 but URL points to v26.4.1, which can mislead users reading release notes.
    • Suggested fix: update the link target to the v26.4.3 tag.
ClickHouse Rules
Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality ⚠️ Changelog entry links to v26.4.1 while claiming v26.4.3
Safe rollout
Compilation time
No large/binary files
Final Verdict
  • Status: ⚠️ Request changes
  • Minimum required actions:
    • Fix the changelog entry URL to point to the v26.4.3 release tag.

@clickhouse-gh clickhouse-gh Bot added pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR. labels Apr 20, 2026
Comment thread contrib/chdig
@azat azat requested review from Algunenano and thevar1able April 20, 2026 16:08
@azat azat enabled auto-merge April 20, 2026 22:15
@azat azat added this pull request to the merge queue Apr 20, 2026
Merged via the queue into ClickHouse:master with commit 83455b9 Apr 20, 2026
159 of 161 checks passed
@azat azat deleted the chdig-v26.4.3 branch April 20, 2026 22:30
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 20, 2026
[source."git+https://github.com/ys-l/flamelens?branch=main"]
git = "https://github.com/ys-l/flamelens"
branch = "main"
[source."git+https://github.com/azat-rust/flamelens?branch=diff-mode"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should switch to the ClickHouse org instead of your own for these deps

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not make a lot of difference, since we bundle them anyway.
This is just a fork with new feature for chdig, I don't think it deserves to be in ClickHouse org

@Algunenano Algunenano self-assigned this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants