Fix KQL parser depth and backtracks counter propagation#103528
Draft
yakov-olkhovskiy wants to merge 41 commits intomasterfrom
Draft
Fix KQL parser depth and backtracks counter propagation#103528yakov-olkhovskiy wants to merge 41 commits intomasterfrom
yakov-olkhovskiy wants to merge 41 commits intomasterfrom
Conversation
…x_parser_depth, max_parser_backtracks, max_query_size as options, set max_parser_depth = 100, max_parser_backtracks = 1000
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…-99530-ci-libfuzzer-for-prs
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml # ci/workflows/pull_request.py Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…ce stacktrace from runner thread instead main
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
…-workflow-conflicts-7a3b # Conflicts: # .github/workflows/pull_request.yml Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
Fix two sanitizer findings from CI run #99740: - Guard `Lexer::nextToken` max-query-size check for null input pointers to avoid UBSan pointer arithmetic exception. - Return early in `HasSubsequenceImpl::hasSubsequenceUTF8` for empty haystack before first UTF-8 decode to avoid MSan uninitialized read exception. Also add targeted parser/gtest and stateless SQL regression coverage for the new edge cases. Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
Co-authored-by: Yakov Olkhovskiy <yakov-olkhovskiy@users.noreply.github.com>
|
|
Member
Author
|
closing AIs mess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a dedicated PR created from commit
8f9090355e872a3cea1f1c54df7f030a8b76e9dd.It fixes KQL parser logic where depth and parser-backtracks counters could be lost while passing through KQL parser components, which could weaken parser-limit accounting and error behavior for complex KQL queries.
Reference PR with related recent parser/CI context: #99740
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Improved KQL parser robustness by preserving parser depth and backtracks counters across KQL parser stages, so parser limits are tracked consistently for complex KQL queries.
Documentation entry for user-facing changes