Mark 03809_time64_not_monotonic as long test#103718
Open
groeneai wants to merge 1 commit intoClickHouse:masterfrom
Open
Mark 03809_time64_not_monotonic as long test#103718groeneai wants to merge 1 commit intoClickHouse:masterfrom
groeneai wants to merge 1 commit intoClickHouse:masterfrom
Conversation
Adds the `long` tag to opt this test into the long-test budget, bypassing the 600s timeout that occasionally hits on the slowest CI lane (`amd_msan, WasmEdge`, ~8x slower than `amd_tsan`). Per @alexey-milovidov directive on PR ClickHouse#102498: ClickHouse#102498 (comment) Triage data: 195,745 runs over 90 days, 10 timeouts (99.995% pass rate), p99 = 404s, max passing = 563s. Pure transient timeout on the slow lane — `long` tag is the right fix per existing precedents (`01049_join_low_card_bug_long`, `01516_drop_table_stress_long`, `01443_merge_truncate_long`). No test logic changed.
Contributor
Author
|
Pre-PR validation gate (per TASK.md Phase 4 step 9)
Session: cron:clickhouse-ci-task-worker:20260429-134500 |
1 task
Contributor
Author
|
cc @alexey-milovidov — could you review this? It's the stabilization PR you asked for on #102498: tags |
Contributor
|
Workflow [PR], commit [815fff6] Summary: ❌
AI ReviewSummaryThis PR adds ClickHouse Rules
Final Verdict
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
longtag totests/queries/0_stateless/03809_time64_not_monotonic.sqlso the test opts into the long-test budget and stops being clipped by the 600s timeout on the slowest CI lane (amd_msan, WasmEdge, ~8x slower thanamd_tsan).Follow-up to @alexey-milovidov directive on #102498 (comment) ("do a stabilization PR, option 2 with tagging the test as
long").Triage data (90 days): 195,745 runs, 10 timeouts (99.995% pass rate), p99 = 404s, max passing = 563s — pure transient timeout, no test bug. Precedents for naming/tagging slow regression tests as
long:01049_join_low_card_bug_long,01516_drop_table_stress_long,01443_merge_truncate_long.One-line change to the
.sqlfile. No test logic touched, no.referencechange.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes