Wire role_arn/role_session_name into Keeper S3 snapshot client#104140
Merged
alexey-milovidov merged 2 commits intomasterfrom May 7, 2026
Merged
Wire role_arn/role_session_name into Keeper S3 snapshot client#104140alexey-milovidov merged 2 commits intomasterfrom
alexey-milovidov merged 2 commits intomasterfrom
Conversation
Pass `role_arn` and `role_session_name` from the auth settings into the `CredentialsConfiguration` used to build the S3 client for Keeper snapshots. The fields and credentials provider chain already exist in the public repo (`AwsAuthSTSAssumeRoleCredentialsProvider`); only this call site in `KeeperSnapshotManagerS3` was missed. The matching change landed in clickhouse-private master in PR ClickHouse/clickhouse-private#2819. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [2541838] Summary: ✅ AI ReviewSummaryThis PR forwards ClickHouse Rules
Final Verdict
|
antonio2368
approved these changes
May 6, 2026
Contributor
LLVM Coverage Report
Changed lines: 100.00% (8/8) · Uncovered code |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
role_arnandrole_session_namefrom the auth settings into theCredentialsConfigurationused when constructing the S3 client for Keeper snapshots. TheAssumeRolecredentials provider chain (AwsAuthSTSAssumeRoleCredentialsProvider) and theS3AuthSettingsfields already exist in the public repo — only this call site inKeeperSnapshotManagerS3was missed when the broader S3AssumeRoleinfrastructure was synced from clickhouse-private. Without this, Keeper snapshot uploads cannot use STS-based authentication even though the rest of the server can.The matching change in clickhouse-private is part of https://github.com/ClickHouse/clickhouse-private/pull/2819.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Honor
role_arnandrole_session_nameauth settings in the Keeper S3 snapshot client, allowing snapshot uploads to use STSAssumeRole-based authentication.Documentation entry for user-facing changes