Update mongo-c-driver to 2.3.0#104300
Merged
Algunenano merged 1 commit intomasterfrom May 7, 2026
Merged
Conversation
Bump mongo-c-driver submodule from 2.2.3 to 2.3.0 using the ClickHouse fork branch ClickHouse/2.3.0, which carries the strerror_l fix for musl/FreeBSD builds and the mlib_have_posix_clocks detection fix. Picks up the CDRIVER-6083 series, which refactors the `reply` ownership contract in the cluster opmsg path and addresses a memory leak observed in CI as a Direct leak of 128 bytes from `bson_copy_to` in `_mongoc_cluster_run_opmsg_recv` (failing test: test_dictionaries_all_layouts_separate_sources/test_mongo.py ::test_simple_ssl). Update version constants in the c-driver cmake wrapper (2.2.2 -> 2.3.0). No new template variables in the upstream config.h.in / mongoc-config.h.in, and the wrapper uses file(GLOB_RECURSE), so the new sources (mongoc-jitter-source, mongoc-retry-backoff-generator, mongoc-retryable-cmd) are picked up automatically. The mongo-cxx-driver wrapper does not need to change: cxx r4.1.4 declares MONGOC_REQUIRED_VERSION 2.0.0, so it is compatible with c-driver 2.3.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [58659cd] Summary: ✅ AI ReviewSummaryThis PR updates ClickHouse Rules
Final Verdict
|
clickhouse-gh
Bot
added
pr-ci
submodule changed
evillique
approved these changes
May 7, 2026
robot-ch-test-poll1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
mongo-c-driverfrom 2.2.3 to 2.3.0 to pick up the CDRIVER-6083 series, which refactors thereplyownership contract in the cluster opmsg path and addresses aLeakSanitizerDirect leak of 128 byte(s)reported frombson_copy_toin_mongoc_cluster_run_opmsg_recv. The leak surfaces flakily astest_dictionaries_all_layouts_separate_sources/test_mongo.py::test_simple_ssl.CC @thevar1able — follow-up to #102842, which calls
mongoc_cleanupfrom~MongoDBInstanceHolderand addressed libmongoc global leaks but did not free this per-cursorbson_treply buffer.Submodule pointer is on the
ClickHouse/mongo-c-driverbranchClickHouse/2.3.0, which carries the existing ClickHouse patches (strerror_lfix for musl/FreeBSD,mlib_have_posix_clocksdetection) on top of upstream tag2.3.0.The
mongo-cxx-driverwrapper does not need to change:r4.1.4declaresMONGOC_REQUIRED_VERSION 2.0.0.CI report where the leak was observed (PR #104231 is unrelated to this change): https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=104231&sha=ba6d691ecc3e9ddd529b269609ff6a98352d6cc5&name_0=PR&name_1=Integration%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20old%20analyzer%2C%203%2F6%29&name_1=Integration%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20old%20analyzer%2C%203%2F6%29
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes