Backport fix for IPv6StringToNumOrDefault to 26.3#104574
Merged
Merged
Conversation
Fix `IPv6StringToNumOrDefault` not properly zeroing output bytes on parse failure. Only one byte was zeroed (`vec_res[i] = 0`) instead of all 16 bytes (`std::fill_n(&vec_res[out_offset], offset_inc, 0)`), causing stale data from previous successful parses to leak into default results. Backport of ClickHouse#93543
Avogar
force-pushed
the
backport/26.3/93543
branch
from
b4e838f to
b4dfe08
Compare
Contributor
|
Workflow [BackportPR], commit [b4dfe08] Summary: ❌
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of fix from #93543
Fix
IPv6StringToNumOrDefaultnot properly zeroing output bytes on parse failure. Only one byte was zeroed (vec_res[i] = 0) instead of all 16 bytes (std::fill_n(&vec_res[out_offset], offset_inc, 0)), causing stale data from previous successful parses to leak into default results.Changelog category: Bug Fix (user-visible misbehavior in an official stable release)
Changelog entry: Fixed
IPv6StringToNumOrDefaultreturning incorrect results when mixed valid and invalid IPv6 strings were processed in the same batch.