Skip to content

Update submodule#105222

Merged
antaljanosbenjamin merged 3 commits into
masterfrom
update-librdkafka-to-2.14.1
May 18, 2026
Merged

Update submodule#105222
antaljanosbenjamin merged 3 commits into
masterfrom
update-librdkafka-to-2.14.1

Conversation

@antaljanosbenjamin
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin commented May 18, 2026 •
edited
Loading

Check the new HOW_TO_UPDATE.md in the submodule to see the difference compared to the official 2.14.1 release.

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Upgrade librdkafka to version 2.14.1

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented May 18, 2026 •
edited
Loading

Workflow [PR], commit [128705f]

Summary: ✅

AI Review

Summary

This PR updates contrib/librdkafka to commit 6aa06cfec6ae35efb6e6f895326ed0ec2ecc2a27 and adjusts one integration test expectation in test_kafka_bad_messages to match the new broker-down message emitted by the upgraded dependency. I reviewed the current diff, prior PR discussion, and CI report, and found no unresolved correctness, safety, performance, or metadata issues that require changes.

Final Verdict

Status: ✅ Approve

@clickhouse-gh clickhouse-gh Bot added pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR. labels May 18, 2026
@Algunenano Algunenano self-assigned this May 18, 2026
@antaljanosbenjamin
Copy link
Copy Markdown
Member Author

antaljanosbenjamin commented May 18, 2026

I force pushed the librdkafka/ClickHouse/release-2.14.1 branch to exclude ClickHouse/librdkafka#17 from the fixes applied because it is not yet merged in ClickHouse and probably causes issues

@antaljanosbenjamin antaljanosbenjamin mentioned this pull request May 18, 2026
Draft
@antaljanosbenjamin antaljanosbenjamin added this pull request to the merge queue May 18, 2026
Merged via the queue into master with commit b166079 May 18, 2026
166 checks passed
@antaljanosbenjamin antaljanosbenjamin deleted the update-librdkafka-to-2.14.1 branch May 18, 2026 20:45
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 18, 2026
This was referenced May 20, 2026
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antaljanosbenjamin @Algunenano @robot-ch-test-poll3