Skip to content

disable obselete settings warning in clickhouse cloud#105485

Open
chhetripradeep wants to merge 1 commit into
ClickHouse:masterfrom
chhetripradeep:disable-obsolete-settings-warning-in-cloud
Open

disable obselete settings warning in clickhouse cloud#105485
chhetripradeep wants to merge 1 commit into
ClickHouse:masterfrom
chhetripradeep:disable-obsolete-settings-warning-in-cloud

Conversation

@chhetripradeep
Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented May 21, 2026

Workflow [PR], commit [a8e1b61]

Summary:

job_name test_name status info comment
Fast test (arm_darwin) DROPPED

AI Review

Summary

This PR suppresses the OBSOLETE_SETTINGS warning in system.warnings when cloud_mode is enabled by skipping getChangedAndObsoleteNames in that mode, and adds a focused stateless test update that verifies the behavior. The change is small, scoped, and consistent with the stated intent; no unresolved correctness, safety, or performance issues were found in the current diff.

Final Verdict

Status: ✅ Approve

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 21, 2026
@alexey-milovidov alexey-milovidov self-assigned this May 21, 2026
@chhetripradeep chhetripradeep force-pushed the disable-obsolete-settings-warning-in-cloud branch from 244ac62 to 7f8d0d9 Compare May 21, 2026 16:47
@chhetripradeep chhetripradeep force-pushed the disable-obsolete-settings-warning-in-cloud branch from 7f8d0d9 to a8e1b61 Compare May 27, 2026 05:11
@chhetripradeep chhetripradeep added the can be tested Allows running workflows for external contributors label May 27, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented May 27, 2026

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.10% 84.20% +0.10%
Functions 91.40% 91.40% +0.00%
Branches 76.60% 76.60% +0.00%

Changed lines: 91.67% (11/12) | lost baseline coverage: 1 line(s) · Uncovered code

Full report · Diff report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants