Skip to content

Do not write preprocessed configs to /etc/#2443

Merged
proller merged 207 commits intoClickHouse:masterfrom
proller:fix14
Nov 27, 2018
Merged

Do not write preprocessed configs to /etc/#2443
proller merged 207 commits intoClickHouse:masterfrom
proller:fix14

Conversation

@proller
Copy link
Copy Markdown
Contributor

@proller proller commented May 29, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@filimonov
Copy link
Copy Markdown
Contributor

👍

Это была одна из претензий наших ОПсов к кликхаусу :)

@proller proller merged commit f1791e9 into ClickHouse:master Nov 27, 2018
proller added a commit to proller/ClickHouse that referenced this pull request Nov 30, 2018
@filimonov
Copy link
Copy Markdown
Contributor

filimonov commented Jan 25, 2019

Small issue with that: when starting clickhouse-server like that

clickhouse-server --config /etc/clickhouse-server/config.xml -- --path=/tmp/bbb --http_port=30000 --tcp_port=30001 --interserver_http_port=30002 --logger.log=/dev/null --logger.errorlog=/dev/null

it still tries to access /var/lib/clickhouse//preprocessed_configs/config.xml (and ALSO writing /tmp/bbb/preprocessed_config)

Did you consider writing to "preprocessed" the values which were overwritten by command line parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants