Skip to content

Syslog logging support#2459

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alex-krash:master
Jun 1, 2018
Merged

Syslog logging support#2459
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alex-krash:master

Conversation

@alex-krash
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

In this PR a logging to syslog has been implemented. For backward compatibility, it is turned on with currently hidden option use_syslog.

@alexey-milovidov
Copy link
Copy Markdown
Member

Why we have

options SYSLOG_CONS | SYSLOG_PID
and LOG_DAEMON facility

for local syslog, but

LOG_USER facility

for rsyslog?

@alex-krash
Copy link
Copy Markdown
Contributor Author

  1. rsyslog does'not support SYSLOG_CONS|SYSLOG_PID options (for local, these option's combination has been taken from existing one implementation)
  2. According to facility, I've picked up existing for local syslog, and used Poco's default for rsyslog. Possibly, to simplify and unify usage, we may use LOG_DAEMON for rsyslog as well.

@alexey-milovidov alexey-milovidov merged commit 726061b into ClickHouse:master Jun 1, 2018
@alexey-milovidov
Copy link
Copy Markdown
Member

So, everything is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants