Add missing UInt128 (UUID) field visitors#2618
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Aug 3, 2018
simPod:uuid-fix
Merged
Add missing UInt128 (UUID) field visitors#2618alexey-milovidov merged 1 commit intoClickHouse:masterfrom simPod:uuid-fix
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
simPod:uuid-fix
Conversation
Member
|
That looks mostly correct. Only few issues remain:
|
Contributor
Author
|
alexey-milovidov
added a commit
that referenced
this pull request
Aug 3, 2018
Member
|
The implementation is still incomplete, but it is better than nothing and now #2611 is fixed. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
TBH, I have just a little idea what I have done here but I tried to address those #1770, #2611
It is not possible to use UUID in WHERE condition. I tried to implement it but need help with that. Not sure if the way I have tried to do this is the right way and whether I should continue, until I resolve all errors or whether it needs another solution.