Fast path for varint read.#2955
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Aug 25, 2018
Merged
Conversation
clickhouse-benchmark <<< 'select count() from s where not ignore(s);' before this patch: ``` QPS: 0.732, RPS: 2346562049.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000. 0.000% 1.310 sec. 10.000% 1.321 sec. 20.000% 1.327 sec. 30.000% 1.337 sec. 40.000% 1.343 sec. 50.000% 1.359 sec. 60.000% 1.366 sec. 70.000% 1.381 sec. 80.000% 1.400 sec. 90.000% 1.434 sec. 95.000% 1.448 sec. 99.000% 1.489 sec. 99.900% 1.499 sec. 99.990% 1.500 sec. ``` after this patch: ``` QPS: 0.787, RPS: 2524560389.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000. 0.000% 1.228 sec. 10.000% 1.232 sec. 20.000% 1.235 sec. 30.000% 1.241 sec. 40.000% 1.246 sec. 50.000% 1.256 sec. 60.000% 1.265 sec. 70.000% 1.278 sec. 80.000% 1.296 sec. 90.000% 1.321 sec. 95.000% 1.354 sec. 99.000% 1.421 sec. 99.900% 1.453 sec. 99.990% 1.456 sec. ``` I also tried a SSE2 implementation and it's much slower (50%)
Member
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clickhouse-benchmark <<< 'select count() from s where not ignore(s);'
before this patch:
after this patch:
I also tried an SSE2 implementation and it's much slower (50%)
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en