Enable optimize_rewrite_sum_if_to_count_if by default

[Algunenano]

Changelog category (leave one):

• Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

• Enable optimize_rewrite_sum_if_to_count_if by default

Documentation entry for user-facing changes

This feature was disabled by default (#41388) because it was buggy. It should not be buggy anymore with the analyzer, so enable it and remove the old interpreter visitor (so people using it will get correct results).

If it ends up being buggy with the analyzer then we'll either fix it or remove the pass

[robot-ch-test-poll4]

This is an automated comment for commit 3b0c4dc with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[devcrafter]

Shouldn't we check the setting around the corresponding pass here ?

[Algunenano]

It is checked inside the pass ->

ClickHouse/src/Analyzer/Passes/SumIfToCountIfPass.cpp

Line 31 in a343406

if (!getSettings().optimize_rewrite_sum_if_to_count_if)

This seems to be the standard way of doing it

[devcrafter]

It is checked inside the pass ->

ClickHouse/src/Analyzer/Passes/SumIfToCountIfPass.cpp

Line 31 in a343406

if (!getSettings().optimize_rewrite_sum_if_to_count_if)

This seems to be the standard way of doing it

Yes. But to me, it looks more natural to do it in src/Analyzer/QueryTreePassManager.cpp where we add pass

[Algunenano]

I hear you, but changing all the setting checks should be part of a different PR.

[devcrafter]

I hear you, but changing all the setting checks should be part of a different PR.

👍
Of course, It isn't something like a call for action here, - more about sharing perception

[Algunenano]

• Fuzzer minimized:

SELECT
    concatWithSeparator(sum(if((number % NULL) = 0, toUInt256(1), toLowCardinality(0))), NULL)
FROM numbers(100)

Already fixed in #62999.

• Broken coverage: Trying to fix in Try to fix coverage tests #63130
• Integration tests (asan, old analyzer) [6/6]: Unrelated, azure.
• Stateless tests (aarch64): Flaky 00992_system_parts_race_condition_zookeeper_long (with Analyzer) #57418 although it seems different now and probably related to recent changes to OPTIMIZE FINAL waiting for merges in RMT (cc @nickitat)
• Stress tests: Unrelated, query reading from dictionary. Not sure if we try to kill active queries