Skip to content

Remove leftovers of GCC support in cmake rules#63488

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:build/remove-gcc-leftovers
May 8, 2024
Merged

Remove leftovers of GCC support in cmake rules#63488
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:build/remove-gcc-leftovers

Conversation

@azat
Copy link
Member

@azat azat commented May 7, 2024

GCC is not supported, and I tried it today for segmented stack (just for fun), but it is not easy to fix, and I guess simply does not worth it.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels May 7, 2024
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented May 7, 2024

This is an automated comment for commit 95b76bf with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this May 8, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue May 8, 2024
Merged via the queue into ClickHouse:master with commit ee36d2a May 8, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 8, 2024
@azat azat deleted the build/remove-gcc-leftovers branch May 8, 2024 03:39
@rschu1ze
Copy link
Member

rschu1ze commented May 8, 2024

COMPILER_CLANG was intentionally kept in to mark code in CMake which are compiler dependent --> #48671 but removing that as well is fine with me.

baibaichen pushed a commit to apache/incubator-gluten that referenced this pull request May 9, 2024
Co-authored-by: kyligence-git <gluten@kyligence.io>

We need merge since rebase failed with ClickHouse/ClickHouse#63488
@azat
Copy link
Member Author

azat commented May 9, 2024

COMPILER_CLANG was intentionally kept in to mark code in CMake which are compiler dependent

Actually there were couple of concerns anyway, i..e why objdump (and other utils) were under COMPILER_CLANG?

And the cmake is the only problem, the code will not compile under gcc anyway (I've tried).

but removing that as well is fine with me.

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants