Remove leftovers of GCC support in cmake rules#63488
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom May 8, 2024
Merged
Remove leftovers of GCC support in cmake rules#63488alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Contributor
|
This is an automated comment for commit 95b76bf with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
alexey-milovidov
approved these changes
May 8, 2024
Member
|
COMPILER_CLANG was intentionally kept in to mark code in CMake which are compiler dependent --> #48671 but removing that as well is fine with me. |
baibaichen
pushed a commit
to apache/incubator-gluten
that referenced
this pull request
May 9, 2024
Co-authored-by: kyligence-git <gluten@kyligence.io> We need merge since rebase failed with ClickHouse/ClickHouse#63488
Member
Author
Actually there were couple of concerns anyway, i..e why objdump (and other utils) were under COMPILER_CLANG? And the cmake is the only problem, the code will not compile under gcc anyway (I've tried).
Great, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC is not supported, and I tried it today for segmented stack (just for fun), but it is not easy to fix, and I guess simply does not worth it.
Changelog category (leave one):