Skip to content

Increase timeout in 02122_join_group_by_timeout for tsan build#65976

Merged
vdimir merged 1 commit intomasterfrom
vdimir/02122_join_group_by_timeout
Jul 30, 2024
Merged

Increase timeout in 02122_join_group_by_timeout for tsan build#65976
vdimir merged 1 commit intomasterfrom
vdimir/02122_join_group_by_timeout

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jul 2, 2024

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Example
https://s3.amazonaws.com/clickhouse-test-reports/65873/b60a0f621709a90af825ba81081bf76cbc1e534d/stateless_tests__tsan__[2_5]/clickhouse-server.log.zst

2024.07.01 08:45:21.508965 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Debug> executeQuery: (from [::1]:47378) (comment: 02122_join_group_by_timeout.sh) SELECT a.name as n FROM ( SELECT 'Name' as name, number FROM system.numbers LIMIT 2000000 ) AS a, ( SELECT 'Name' as name2, number FROM system.numbers LIMIT 2000000 ) as b FORMAT Null SETTINGS max_execution_time = 1, timeout_overflow_mode = 'break'  (stage: Complete)
2024.07.01 08:45:24.644541 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> Planner: Query to stage Complete
2024.07.01 08:45:24.646366 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> Planner: Query to stage Complete
2024.07.01 08:45:24.650905 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> Planner: Query from stage FetchColumns to stage Complete
2024.07.01 08:45:24.666125 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> Planner: Query to stage Complete
2024.07.01 08:45:24.667823 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> Planner: Query from stage FetchColumns to stage Complete
2024.07.01 08:45:24.669991 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> HashJoin: Keys: , datatype: EMPTY, kind: Cross, strictness: Unspecified, right header: __table3.name2 String Const(size = 0, String(size = 1))
2024.07.01 08:45:24.671363 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Trace> Planner: Query from stage FetchColumns to stage Complete
2024.07.01 08:45:25.042867 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Error> executeQuery: Code: 210. DB::NetException: I/O error: Broken pipe, while writing to socket ([::1]:9000 -> [::1]:47378). (NETWORK_ERROR) (version 24.7.1.657) (from [::1]:47378) (comment: 02122_join_group_by_timeout.sh) (in query: SELECT a.name as n FROM ( SELECT 'Name' as name, number FROM system.numbers LIMIT 2000000 ) AS a, ( SELECT 'Name' as name2, number FROM system.numbers LIMIT 2000000 ) as b FORMAT Null SETTINGS max_execution_time = 1, timeout_overflow_mode = 'break' ), Stack trace (when copying this message, always include the lines below):
2024.07.01 08:45:25.104299 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Error> TCPHandler: Can't send logs to client: Code: 210. DB::NetException: I/O error: Broken pipe, while writing to socket ([::1]:9000 -> [::1]:47378). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):
2024.07.01 08:45:25.104636 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Error> TCPHandler: Code: 210. DB::NetException: I/O error: Broken pipe, while writing to socket ([::1]:9000 -> [::1]:47378). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):
2024.07.01 08:45:25.105131 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Warning> TCPHandler: Client has gone away.
2024.07.01 08:45:25.105280 [ 2933 ] {dbca536d-81c2-41ca-88ab-f18b99191076} <Debug> TCPHandler: Processed in 7.046463662 sec.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@divanik divanik self-assigned this Jul 2, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jul 2, 2024

This is an automated comment for commit 0f29f89 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir enabled auto-merge July 2, 2024 15:49
@vdimir vdimir closed this Jul 29, 2024
auto-merge was automatically disabled July 29, 2024 09:54

Pull request was closed

@vdimir vdimir force-pushed the vdimir/02122_join_group_by_timeout branch from 5fff3b1 to 37210d2 Compare July 29, 2024 09:54
@vdimir vdimir reopened this Jul 29, 2024
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jul 30, 2024

Stress test (debug) — Found signal in gdb.log Details

#66026

@vdimir vdimir added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 30, 2024
@vdimir vdimir added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit 240628d Jul 30, 2024
@vdimir vdimir deleted the vdimir/02122_join_group_by_timeout branch July 30, 2024 09:46
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants