Skip to content

Let's Encrypt integration#66315

Merged
thevar1able merged 83 commits intomasterfrom
lets-finally-encrypt
Nov 12, 2025
Merged

Let's Encrypt integration#66315
thevar1able merged 83 commits intomasterfrom
lets-finally-encrypt

Conversation

@thevar1able
Copy link
Copy Markdown
Member

@thevar1able thevar1able commented Jul 10, 2024 •
edited
Loading

Changelog category (leave one):

  • Experimental Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support TLS certificates retrieval from ACME providers, RFC 8555.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

Continuation of #48661

Config sample

<acme>
    <email>var1able+acme@var1able.network</email>
    <terms_of_service_agreed>true</terms_of_service_agreed>
    <domains>
        <domain>letsencrypt-stg.var1able.network</domain>
    </domains>
</acme>

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR. labels Jul 10, 2024
@robot-ch-test-poll3

This comment was marked as outdated.

Sign in to view
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch 2 times, most recently from bd58875 to fd1f522 Compare July 11, 2024 13:46
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch from a5fd82a to 78bcd5d Compare July 17, 2024 14:40
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch from 78bcd5d to c056012 Compare August 11, 2024 21:16
@robot-ch-test-poll robot-ch-test-poll removed the submodule changed At least one submodule changed in this PR. label Aug 14, 2024
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch 2 times, most recently from 0c8b851 to 37c1c7a Compare August 25, 2024 21:39
thevar1able
thevar1able commented Sep 6, 2024
View reviewed changes
thevar1able
thevar1able commented Sep 6, 2024
View reviewed changes
thevar1able
thevar1able commented Sep 6, 2024
View reviewed changes
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch 2 times, most recently from 8b6ee8f to b7edeae Compare November 11, 2024 00:41
@thevar1able

This comment was marked as outdated.

Sign in to view
@thevar1able thevar1able mentioned this pull request Mar 2, 2025
Closed
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch from a9ca890 to 92e1a9d Compare March 2, 2025 18:16
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 2, 2025 •
edited
Loading

Workflow [PR], commit [28aa43d]

@thevar1able thevar1able force-pushed the lets-finally-encrypt branch from ba65630 to 4bc3f9c Compare March 20, 2025 15:12
@thevar1able thevar1able marked this pull request as ready for review March 20, 2025 19:06
@thevar1able thevar1able requested a review from Copilot March 28, 2025 15:57

This comment was marked as outdated.

Sign in to view

GrigoryPervakov
GrigoryPervakov reviewed Apr 4, 2025
View reviewed changes
@thevar1able thevar1able force-pushed the lets-finally-encrypt branch from 5a3ac27 to 6a06982 Compare June 3, 2025 13:39
@azat azat self-assigned this Jun 9, 2025
@thevar1able
Fix exception code
89b33c4
@thevar1able
Start reissuing process if just one certificate is expired
58842df
@thevar1able
Simplify refreshKeyTask
6da3797
@thevar1able
Lint
994b33c
@thevar1able
Move Directory::parse to cpp
94afd4e
@thevar1able
Lint
a0d82af
@thevar1able
Remove redundant function
4cf6fc4
@thevar1able
Fix invalid X509Certificate::expiresOn()
3c7de3c
@thevar1able
Adjust expiration time in test configs
e31043a
@thevar1able
Generalize X509Certificate::fromFile() and `X509Certificate::fromBu…
7a1695a 
…ffer()`
@thevar1able
Put ACME request handler to its own file
d6d0a18
@thevar1able
Fix retries
f6ec343
@thevar1able
Lint tests
f1bace8
@thevar1able
Fix checking order lock status
2d58ebf
@thevar1able
Add zk->sync()
f001183
@thevar1able
More than one chanllenge in tests is ok
92620bb
@thevar1able
Use ephemeral nodes for challenges
69efc94
@thevar1able
Wait longer if we got asked about a challenge, but did not initialize…
c5bec48 
… key yet
@thevar1able
Fix style
799992a
@thevar1able
Reorder configuration parsing
ddb6e4f
@thevar1able
Copy link
Copy Markdown
Member Author

thevar1able commented Nov 12, 2025 •
edited
Loading

Intentionally merging without approval.

@thevar1able thevar1able added this pull request to the merge queue Nov 12, 2025
Merged via the queue into master with commit b92aa37 Nov 12, 2025
124 of 130 checks passed
@thevar1able thevar1able deleted the lets-finally-encrypt branch November 12, 2025 19:15
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 12, 2025
@thevar1able thevar1able mentioned this pull request Dec 12, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrigoryPervakov GrigoryPervakov GrigoryPervakov left review comments

@rschu1ze rschu1ze rschu1ze left review comments

Copilot code review Copilot Copilot left review comments

@azat azat Awaiting requested review from azat

Assignees

No one assigned

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@thevar1able @robot-ch-test-poll3 @azat @GrigoryPervakov @rschu1ze @robot-clickhouse @robot-ch-test-poll @Lokhmat