Skip to content

[CI Fest] Fix flaky performance test decimal_aggregates#67044

Merged
alesapin merged 5 commits intomasterfrom
make_decimal_aggregates_less_memory_extensive
Jul 25, 2024
Merged

[CI Fest] Fix flaky performance test decimal_aggregates#67044
alesapin merged 5 commits intomasterfrom
make_decimal_aggregates_less_memory_extensive

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jul 24, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Split query into multiple queries to consume less memory at once + use less data. Fixes #67034.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@alesapin alesapin added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 24, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jul 24, 2024

This is an automated comment for commit 4ee4090 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@vdimir vdimir self-assigned this Jul 24, 2024
@alesapin
Copy link
Copy Markdown
Member Author

Aaand not it's unstable
image

Comment thread tests/performance/decimal_aggregates.xml
Comment thread tests/performance/decimal_aggregates.xml
@alesapin
Copy link
Copy Markdown
Member Author

Okay, two unstable but at least it doesn't crash with OOM

@alesapin alesapin enabled auto-merge July 25, 2024 12:09
@alesapin alesapin added this pull request to the merge queue Jul 25, 2024
Merged via the queue into master with commit 5c5682b Jul 25, 2024
@alesapin alesapin deleted the make_decimal_aggregates_less_memory_extensive branch July 25, 2024 22:40
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance test decimal_aggregates is flaky

4 participants