Skip to content

no-msan 00314_sample_factor_virtual_column#67874

Merged
al13n321 merged 1 commit intomasterfrom
omnomsan
Aug 6, 2024
Merged

no-msan 00314_sample_factor_virtual_column#67874
al13n321 merged 1 commit intomasterfrom
omnomsan

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Aug 5, 2024

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

It sometimes times out because aggregating 6M rows takes > 10 minutes with MSAN, somehow. I didn't investigate why, but here's a PR to disable this test with MSAN.

(Specifically, log says that most of the 10 minutes were spent on the 2 SELECTs, and the first SELECT says this near the end: "Aggregated. 1000000 to 1 rows (from 7.63 MiB) in 242.829221645 sec. (4118.121 rows/sec., 32.17 KiB/sec.)".)

Looking at histogram of how long this test takes with MSAN over lots of runs, it has a weirdly long tail: [1] - mode is ~1 minute, but all values >~5 minutes occur with ~equal small frequency.

[1] https://play.clickhouse.com/play?user=play#U0VMRUNUCiAgICBpbnREaXYodGVzdF9kdXJhdGlvbl9tcyBhcyBtcywgMTAwMDApKjEwIGFzIGJ1Y2tldCwKICAgIGNvdW50KCksCkZST00gY2hlY2tzCldIRVJFICgobm93KCkgLSB0b0ludGVydmFsRGF5KDEwKSkgPD0gY2hlY2tfc3RhcnRfdGltZSkgQU5EIGNoZWNrX25hbWUgPSAnU3RhdGVsZXNzIHRlc3RzIChtc2FuKSBbMi80XScgYW5kIHRlc3RfbmFtZSA9ICcwMDMxNF9zYW1wbGVfZmFjdG9yX3ZpcnR1YWxfY29sdW1uJyBhbmQgdGVzdF9zdGF0dXMgIT0gJ1NLSVBQRUQnCmdyb3VwIGJ5IGJ1Y2tldApvcmRlciBieSBidWNrZXQ=

@rschu1ze rschu1ze self-assigned this Aug 5, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Aug 5, 2024

This is an automated comment for commit bf2e679 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 5, 2024
@al13n321 al13n321 enabled auto-merge August 5, 2024 23:11
@al13n321 al13n321 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into master with commit bb71c1e Aug 6, 2024
@al13n321 al13n321 deleted the omnomsan branch August 6, 2024 05:19
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants