Conversation
rschu1ze
approved these changes
Aug 5, 2024
Contributor
|
This is an automated comment for commit bf2e679 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
It sometimes times out because aggregating 6M rows takes > 10 minutes with MSAN, somehow. I didn't investigate why, but here's a PR to disable this test with MSAN.
(Specifically, log says that most of the 10 minutes were spent on the 2 SELECTs, and the first SELECT says this near the end: "Aggregated. 1000000 to 1 rows (from 7.63 MiB) in 242.829221645 sec. (4118.121 rows/sec., 32.17 KiB/sec.)".)
Looking at histogram of how long this test takes with MSAN over lots of runs, it has a weirdly long tail: [1] - mode is ~1 minute, but all values >~5 minutes occur with ~equal small frequency.
[1] https://play.clickhouse.com/play?user=play#U0VMRUNUCiAgICBpbnREaXYodGVzdF9kdXJhdGlvbl9tcyBhcyBtcywgMTAwMDApKjEwIGFzIGJ1Y2tldCwKICAgIGNvdW50KCksCkZST00gY2hlY2tzCldIRVJFICgobm93KCkgLSB0b0ludGVydmFsRGF5KDEwKSkgPD0gY2hlY2tfc3RhcnRfdGltZSkgQU5EIGNoZWNrX25hbWUgPSAnU3RhdGVsZXNzIHRlc3RzIChtc2FuKSBbMi80XScgYW5kIHRlc3RfbmFtZSA9ICcwMDMxNF9zYW1wbGVfZmFjdG9yX3ZpcnR1YWxfY29sdW1uJyBhbmQgdGVzdF9zdGF0dXMgIT0gJ1NLSVBQRUQnCmdyb3VwIGJ5IGJ1Y2tldApvcmRlciBieSBidWNrZXQ=