Fix NATS integration tests

[dmitry-sles-novikov]

Ref: #53241

Changelog category:

• Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

• restore deleted NATS integration tests and fix errors.
• fixed some race conditions in NATS engine
• fixed data loss when streaming data to NATS in case of connection loss
• fixed freeze of receiving the last chunk of data when streaming from NATS ended
• nats_max_reconnect is deprecated and has no effect, reconnect is performed permanently with nats_reconnect_wait timeout

CI Settings (Only check the boxes if you know what you are doing):

• Allow: All Required Checks
• Allow: Stateless tests
• Allow: Stateful tests
• Allow: Integration Tests
• Allow: Performance tests
• Allow: All Builds
• Allow: batch 1, 2 for multi-batch jobs
• Allow: batch 3, 4, 5, 6 for multi-batch jobs

---

• Exclude: Style check
• Exclude: Fast test
• Exclude: All with ASAN
• Exclude: All with TSAN, MSAN, UBSAN, Coverage
• Exclude: All with aarch64, release, debug

---

• Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
• Exclude: AST fuzzers

---

• Do not test
• Woolen Wolfdog
• Upload binaries for special builds
• Disable merge-commit
• Disable CI cache

[dmitry-sles-novikov]

"Changelog category" fixed

[antaljanosbenjamin]

I fixed the description, no the PR Check should pass. Hope you don't mind, it was faster to do it than to explain what to do.

[antaljanosbenjamin]

Now everything should be fine, I think. Let's see. If it doesn't trigger a proper rerun, please merge master or rebase on current master to trigger a new run of CI.

[robot-ch-test-poll4]

This is an automated comment for commit 2edd2be with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
BuzzHouse (asan)	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
BuzzHouse (debug)	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
BuzzHouse (msan)	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
BuzzHouse (tsan)	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
BuzzHouse (ubsan)	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs ClickBench with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[dmitry-sles-novikov]

all tests except test_storage_s3_queue/test.py::test_alter_settings passed. I am ready to continue review

[antaljanosbenjamin]

Sorry for missing out on the review, I was flooded with other issues, got sick and now I am on holidays. I will try to get back to this as soon as possible and take care of it.

[antaljanosbenjamin]

Great work! I will try to merge a recent master. If I cannot manage it (meaning you disabled it), then I will ask you to do it. After that I can merge it.

[dmitry-sles-novikov]

@antaljanosbenjamin, is there something wrong with the PR?

P.S. At the next step, I plan to change the async model of receiving messages by nats consumer to synchronous, and then implement support for jet stream.

[antaljanosbenjamin]

Sorry, I missed this PR. So the PR seems okay, however the CI was really bad, thus I didn't have the confidence to merge the PR. Right now as far as I see we have issues with PR that are coming from a fork repo. Once the fix is done I will merge master again and make another attempt to merge this PR.

Thank you for your understanding, I will focus on this PR more.

[maxknv]

Sorry, I missed this PR. So the PR seems okay, however the CI was really bad, thus I didn't have the confidence to merge the PR. Right now as far as I see we have issues with PR that are coming from a fork repo. Once the fix is done I will merge master again and make another attempt to merge this PR.

Thank you for your understanding, I will focus on this PR more.

@antaljanosbenjamin this ci run has not beed affected by that issue. the issue was in checking out a fork repo which failed right at the beginning and blocked everything else

[antaljanosbenjamin]

this ci run has not beed affected by that issue

Yes the last run long ago, but I wasn't sure if the issue would affect this PR or not. I was expecting that to be merged soon (I saw on slack you are working on it), so I opted to wait for you PR.

[maxknv]

Yes the last run long ago, but I wasn't sure if the issue would affect this PR or not. I was expecting that to be merged soon (I saw on slack you are working on it), so I opted to wait for you PR.

I see. The branch can be updated now, if needed. That issue is fixed on master

[antaljanosbenjamin]

I don't see any NATS related issues in the postprocessed gdb log, I will merge this PR.