Increase max_rows_to_read limit in some tests#70617
Increase max_rows_to_read limit in some tests#70617Algunenano merged 2 commits intoClickHouse:masterfrom
Conversation
|
This is an automated comment for commit ddf3259 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
|
Can we change it inside tests that read from text_log? |
9edbffe to
d9bcc66
Compare
|
IMO it either should be global or we need a check like the one for presence of filtering by |
| "http_receive_timeout": timeout, | ||
| "http_send_timeout": timeout, | ||
| "output_format_parallel_formatting": 0, | ||
| "max_rows_to_read": 0, # Some queries read from system.text_log which might get too big |
There was a problem hiding this comment.
Ok. Although I don't understand this change - if we unlock it in some tests, what is the point for unlocking it globally here?
PS. Anyways, the changes LGTM. Thank you!
There was a problem hiding this comment.
AFAIK this is not global, it's only used when executing SQL queries inside clickhouse-test (for internal usage).
Backport #70617 to 24.9: Increase max_rows_to_read limit in some tests
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Increase max_rows_to_read limit in some tests.
Some tests reading from system.text_log, such as
02796_calculate_text_stack_trace,02581_share_big_sets_between_mutation_tasks_long,02581_share_big_sets_between_multiple_mutations_tasks_longfail spuriously as they reach this limit.Introduced in #66837
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):