Skip to content

Fix build issue of contrib/openssl.#72622

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
RinChanNOWWW:fix-openssl-cmake
Dec 26, 2024
Merged

Fix build issue of contrib/openssl.#72622
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
RinChanNOWWW:fix-openssl-cmake

Conversation

@RinChanNOWWW
Copy link
Copy Markdown
Contributor

@RinChanNOWWW RinChanNOWWW commented Nov 29, 2024

Summary

On my machine (Centos 8.2 with perl v5.26.3), I can't build contrib/openssl of the latest master branch because the compiler can't find the required asm files (just like #70713).

It is because such codes in contrib/openssl-cmake/CMakeLists.txt do not work actually:

macro(perl_generate_asm FILE_IN FILE_OUT)
    # Manually set $CC because the called Perl scripts require it.
    add_custom_command(OUTPUT ${FILE_OUT}
        COMMAND ${CMAKE_COMMAND} -E env "CC=${CMAKE_CXX_COMPILER}" /usr/bin/env perl ${FILE_IN} ${FILE_OUT})
endmacro()

${FILE_OUT}s are not generated actually because their parent directories don't exist. We should make parent directories first.

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix the issue that asm files of contrib openssl cannot be generated

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

@RinChanNOWWW
Copy link
Copy Markdown
Contributor Author

PTAL @alexey-milovidov

Comment thread contrib/openssl-cmake/CMakeLists.txt Outdated
@alexey-milovidov alexey-milovidov self-assigned this Nov 29, 2024
@erickurbanov
Copy link
Copy Markdown
Contributor

the problem is relevant for ubuntu 22.04 on my cloud machine

@alexey-milovidov
Copy link
Copy Markdown
Member

@RinChanNOWWW, do you think, bash is needed, or we can use sh?
bash is strictly stronger than sh, but it can be unavailable.

@RinChanNOWWW
Copy link
Copy Markdown
Contributor Author

@RinChanNOWWW, do you think, bash is needed, or we can use sh?

bash is strictly stronger than sh, but it can be unavailable.

sh is just OK.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Dec 25, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR. labels Dec 25, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Dec 25, 2024

This is an automated comment for commit 62fed6f with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Dec 26, 2024
Merged via the queue into ClickHouse:master with commit 4f5938d Dec 26, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 26, 2024
@RinChanNOWWW RinChanNOWWW deleted the fix-openssl-cmake branch December 26, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants