Fix build issue of contrib/openssl.#72622
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Dec 26, 2024
Merged
Conversation
Contributor
Author
|
PTAL @alexey-milovidov |
Contributor
|
the problem is relevant for ubuntu 22.04 on my cloud machine |
Member
|
@RinChanNOWWW, do you think, |
32aa9d0 to
62fed6f
Compare
Contributor
Author
sh is just OK. |
alexey-milovidov
approved these changes
Dec 25, 2024
Contributor
|
This is an automated comment for commit 62fed6f with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On my machine (Centos 8.2 with perl v5.26.3), I can't build contrib/openssl of the latest master branch because the compiler can't find the required asm files (just like #70713).
It is because such codes in contrib/openssl-cmake/CMakeLists.txt do not work actually:
${FILE_OUT}s are not generated actually because their parent directories don't exist. We should make parent directories first.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the issue that asm files of contrib openssl cannot be generated
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):