Skip to content

Lower PREWHERE log level#73116

Merged
vdimir merged 2 commits intomasterfrom
vdimir/fix_prewhere_log_level
Dec 12, 2024
Merged

Lower PREWHERE log level#73116
vdimir merged 2 commits intomasterfrom
vdimir/fix_prewhere_log_level

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Dec 11, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Log PREWHERE conditions with Test level

Motivation: When searching in text_log, you often filter message by a specific substring. However, if you run the same or a slightly modified query again, you'll get a large number of spam messages from the previous SELECT run on text_log, because the substring appears in where conditions as well, making it harder to work with logs.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label Dec 11, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Dec 11, 2024

This is an automated comment for commit 277b278 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir force-pushed the vdimir/fix_prewhere_log_level branch from 286b070 to bdefff4 Compare December 11, 2024 13:27
@nickitat nickitat self-assigned this Dec 11, 2024
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Dec 12, 2024

Mergeable Check — failed: Integration tests (asan, old analyzer) [5/6]
Integration tests (asan, old analyzer) [5/6] — fail: 1, passed: 554 Details

#73096

@vdimir vdimir enabled auto-merge December 12, 2024 08:45
@vdimir vdimir added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 93049da Dec 12, 2024
@vdimir vdimir deleted the vdimir/fix_prewhere_log_level branch December 12, 2024 13:25
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 12, 2024
@SaltTan
Copy link
Copy Markdown
Contributor

SaltTan commented Dec 13, 2024

Looking in the log was the only way to find out which conditions are being moved to prewhere :(

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Dec 13, 2024

@SaltTan you may use EXPLAIN PLAN actions = 1 to check out what have been pushed down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants